Replace model-not-found Service with Envoy direct_response EnvoyFilter#60
Merged
techworldhello merged 1 commit intoMay 13, 2026
Merged
Conversation
rambohe-ch
requested review from
Fei-Guo,
techworldhello and
zhuangqh
as code owners
- charts/modelharness: add envoyfilter-not-found.yaml that patches a catch-all 404 (OpenAI-compatible JSON) onto each per-namespace Gateway via Envoy direct_response. - charts/modelharness: delete httproute-not-found.yaml and referencegrant.yaml; remove modelNotFound block from values.yaml. - hack/e2e/scripts/install-components.sh: drop install_model_not_found function, its phase1-base invocation, and the unused MANIFESTS_DIR. - hack/e2e/scripts/validate-components.sh: drop the cluster-shared model-not-found Pod readiness check. - test/e2e/utils: remove ModelNotFoundNamespace/PodLabel constants and the unused HTTPRouteGVK/ReferenceGrantGVK; refresh setup.go and helm.go doc comments. - test/e2e/model_routing_test.go: rewrite 'Model-specific route wins over catch-all' to assert HTTP 200 + matching response body model (the old nginx access-log probe no longer applies); drop unused countNginxAccessLogs helper and kubernetes import. - test/e2e/gpu_mocker_test.go: refresh comments for the unknown-model 404 spec to describe the EnvoyFilter direct_response. - docs: update test/e2e/README.md and production-stack-E2E-test-scenarios.md to reflect the new design.
rambohe-ch
force-pushed
the
imporve-model-not-found
branch
2 times, most recently
from
a70a8d2 to
62afd8a
Compare
techworldhello
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Requirements
Issue Fixed:
Notes for Reviewers: