fix: added hp support for legacy games#1397
Open
dmportella wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix HP updates not working on Roll20 legacy game sheets by adding fallback detection for
window.vttEngine === "legacy".Type of change
Motivation & context
Legacy Roll20 games don't have
character.characterSheetset at all, so the existing check forogl5eordnd5esheet short names never matched, causing HP updates to silently fail on legacy games.What changed?
src/roll20/page-script.js: Addedwindow.vttEngine === "legacy"as an additional condition in the character sheet check, falling back to the 2014 sheet handling for legacy games.How to test
Reviewer notes
Legacy games have no
characterSheetproperty at all, so there's no sheet version to check — the fallback to 2014 sheet logic is the safest default.