-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[not-for-merge] [src] Adding binary lattice-to-ngram-counts #2778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[not-for-merge] [src] Adding binary lattice-to-ngram-counts #2778
Conversation
… a binary lattice-to-ngram-counts
@m-wiesner was this code, or something similar to it, ever added to the main branch? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@david-ryan-snyder, @m-wiesner, where we are at this? |
This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open. |
@david-ryan-snyder, @m-wiesner, friendly ping? |
I think it's OK to merge but it's not used in any recipes. We can just leave the PR up, I think, in case people need it, and if it seems useful for anything we want to commit we can merge it. |
Agree, it makes no sense to maintain unused code. |
This PR adds a binary called lattice-to-ngram-counts that computes n-label softcounts over input lattices.
Note that this binary may need to be used in conjunction with lattice-expand-ngram (https://github.com/kaldi-asr/kaldi/blob/master/src/latbin/lattice-expand-ngram.cc) so that each arch as a unique n-label history.
The PR is currently "not-for-merge" but may be added to the main branch at some point.
@m-wiesner