Change num egs for combination in chain training script #4932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpovey
reviewed
Oct 22, 2024
| @@ -593,7 +593,7 @@ def train(args, run_opts): | |||
| chain_lib.combine_models( | |||
| dir=args.dir, num_iters=num_iters, | |||
| models_to_combine=models_to_combine, | |||
| num_chunk_per_minibatch_str=args.num_chunk_per_minibatch, | |||
| num_chunk_per_minibatch_str="1:64", | |||
There was a problem hiding this comment.
the right fix IMO would be to change this from the calling script by setting the option. This change causes it to ignore the option, and I'm concerned it would affect existing scripts where the option is used.
|
This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing increasingly smaller minibatch sizes when combining models helps to avoid a crash when there isn't enough data to form one minibatch.