[patch] [v1.3.2] Multi-party and DX Fixes and Enhancements #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etried Messages Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
…de Identity Check Metrics Signed-off-by: hfuss <hayden.fuss@kaleido.io> renaming dxconnect callback since it isnt an event persay Signed-off-by: hfuss <hayden.fuss@kaleido.io> fix linter and tests Signed-off-by: hfuss <hayden.fuss@kaleido.io> register node sets metric too Signed-off-by: hfuss <hayden.fuss@kaleido.io> cleaned up code and tests Signed-off-by: hfuss <hayden.fuss@kaleido.io> getting test coverage up Signed-off-by: hfuss <hayden.fuss@kaleido.io> nearly all test coverage Signed-off-by: hfuss <hayden.fuss@kaleido.io> 100% coverage Signed-off-by: hfuss <hayden.fuss@kaleido.io> checking nodeidentitystatus on confirmed identity changes and orchestrator startup Signed-off-by: hfuss <hayden.fuss@kaleido.io> nearly full coverage Signed-off-by: hfuss <hayden.fuss@kaleido.io> 100% coverage, again Signed-off-by: hfuss <hayden.fuss@kaleido.io> trigger test Signed-off-by: hfuss <hayden.fuss@kaleido.io> PR feedback Signed-off-by: hfuss <hayden.fuss@kaleido.io> extend timeout to 45s Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in cherry picked commits from the upstream:
This allows us to monitor DX<->node identities more easily, and when private messages fail to send, retry them more reliably and w/o incorrectly re-marking successful messages as pending.