-refactor: activeHandlerContext to invocation context with authRef#16
Open
ka1ii wants to merge 5 commits into
Open
-refactor: activeHandlerContext to invocation context with authRef#16ka1ii wants to merge 5 commits into
ka1ii wants to merge 5 commits into
Conversation
…typescript into wfe-sdk-authref
…typescript into wfe-sdk-authref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor activeHandlerContext to Invocation Context
The existing activeHandlerContext stores
authTokenandrequestIdfor an given invocation in the handler runtime one-to-one. This presents two problemsRace condition when handler runtime dispatches multiple messages asynchronously
Scenario:
AuthRef
AuthRef is per transaction while requestId and authToken are per invocation, meaning when we handle batch + parallel invocation modes, we would need a way to store the authref on a per transaction basis.
AsyncLocalStorage for storing handlerContext
AsyncLocalStorage lets us to safely store the activeHandlerContext within the confines of a callback, solving both of the problems that we currently have.
It also eliminates solutions that requires custom data structure inside of handler runtime.