Skip to content

Conversation

@raeesnazeer
Copy link
Contributor

No description provided.

@raeesnazeer raeesnazeer mentioned this pull request Oct 8, 2021
3 tasks
Copy link
Contributor

@LorDDark6660 LorDDark6660 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong

Copy link
Contributor

@LorDDark6660 LorDDark6660 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems okay

@silence48
Copy link
Contributor

perhaps the web app should automatically add the home-domain to the account upon the creation of the token?


### What is this task?

One of the major feature of stellar blockchain is tokens, creating a token on stellar blockchain is very simple, yet lot of people do not know how to make one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use Stellar instead of stellar?

- The code should be checked to insure the issuers wallet is generated correctly and locked.

## Links
- [Stellar js SDK](https://github.com/stellar/js-stellar-sdk)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal. But js should change to JS


The website should have the following options:
* Users should be able to select their asset-codes, total suppy and home domain of token as per their choice.
* It should automatically create a issuer wallet and transfe the generated token to the users wallet and lock the issuer account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: an issuer wallet
Typo: transfer
Typo: user's wallet

- UI is not of primary importance but there should at least be a basic layout.
- The code quality is also not primarily important but should function properly and be reasonably reviewable.
- Check the if the token is issued correctly.
- The code should be checked to insure the issuers wallet is generated correctly and locked.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mistook insure withensure right?

Typo: issuer's wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants