Allow tuples as parameters for smartcontract proposals#312
Open
fedepo wants to merge 4 commits intokalidao:mainfrom
Open
Allow tuples as parameters for smartcontract proposals#312fedepo wants to merge 4 commits intokalidao:mainfrom
fedepo wants to merge 4 commits intokalidao:mainfrom
Conversation
|
@fedepo is attempting to deploy a commit to the KaliCo Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@audsssy any chance you can take a look at this / merge it? We tested this quite a bit and used on our verbal deployment successfully. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some smartcontracts require tuple[] as input parameters.
When that's the case, the user will want to pass a JSON formatted array (as they'd do on Etherscan).
This little fix checks if the input provided is a JSON. If it is, it will parse the JSON and pass it as an array to the function that creates the payload. If it's not a JSON string, it will just pass it as is.
for context, discord thread is here:
https://discord.com/channels/923399898769018921/1161730434120548413