Skip to content

Conversation

ildar170975
Copy link
Collaborator

Before:
image

  - type: grid
    columns: 2
    square: false
    title: not square
    cards:
      - &ref_graph_card
        type: custom:mini-graph-card
        entities:
          - entity: sensor.xiaomi_cg_1_co2
      - &ref_entity_card
        type: entity
        entity: sun.sun
      - *ref_entity_card
      - *ref_graph_card

  - type: grid
    columns: 2
    square: true
    title: square
    cards:
      - *ref_graph_card
      - *ref_entity_card
      - *ref_entity_card
      - *ref_graph_card

After:
image

Probably may be useful in case of using a new experimental "sections" views (honestly, do not care about this still beta feature).

@akloeckner akloeckner changed the title fix height in Grid fix: height in grid Oct 2, 2024
@akloeckner
Copy link
Collaborator

Should we then merge this after #1139 ?

(honestly, do not care about this still beta feature)

What do you mean by this? Are sections still beta?

@ildar170975
Copy link
Collaborator Author

Are sections still beta?

Yes, still experimental... But many beginners use it and some of them seems like unaware about the old-style working way...

@ildar170975
Copy link
Collaborator Author

ildar170975 commented Oct 2, 2024

Should we then merge this after #1139 ?

Recently got home, have not seen this PR yet.

@ildar170975
Copy link
Collaborator Author

Based on my estimation of users using sections: I would say that my PR may come first )))))

@Nickduino

This comment was marked as off-topic.

@ildar170975

This comment was marked as off-topic.

@akloeckner
Copy link
Collaborator

I checked this out and, yes, it fixes the height of the card to the required grid rows... But: The graph remains very miniature and squashed to the bottom:

image

That is not what I would expect. I would expect the graph to fill the space defined by the number of rows...

I created #1199, which has my current working state based on the original sections PR. But I stripped out all the advanced features for the time being. Could you check this out and let me know, if this feels more intuitive to you, too? (It does for me.)

@Nickduino

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants