Closed — draft moved to internal review - #53
Closed
zoharbabin wants to merge 4 commits into
Closed
Conversation
There is no backend primitive for structured per-user key/value facts today, and none is being added by this change — this is a design contract only, per issue #38's own "How" section: design the SDK-side interface first so the backend team has a concrete shape to review. Adds docs/PROPOSED-APIS.md, a new registry for capabilities blocked on backend work that don't have a home in API-REFERENCE.md yet (which documents only shipped behavior). Its Memory section specifies Memory.set/get/list/delete signatures, admin-KS scoping rationale, error semantics (missing user, missing key, oversized value, conflict, delete idempotency), and how it stays additive to existing full-transcript-replay integrations. Explicitly labeled NOT IMPLEMENTED / not reviewed by the backend team — a draft, not an in-progress feature. Cross-links this new doc from API-REFERENCE.md (Contents + a new Memory subsection under Management Operations) and README.md (Honest limits + Reference table) so it's discoverable, not buried in an issue comment. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Self-review caught a factual error: docs/PROPOSED-APIS.md claimed Threads.delete()'s existing requireConfirm() throws bad_request; it actually throws confirmation_required (src/management/agents.js). Corrects the proposed Memory.delete() contract to reuse that existing code instead of inventing a new precondition_required one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
audit-pr53-clean found docs/PROPOSED-APIS.md:144 claiming assertKind() throws forbidden; it actually throws wrong_token_scope, per src/management/client.js and the convention used in avatar-sessions.js. Also fixed the guard name referenced (assertKind, not assertAdmin).
The original draft assumed an integrator manually calls Memory.get() and wires it into request_vars every turn. That's only as reliable as every integrator's own discipline, and the same flaw applies whether facts live in Kaltura's own storage or a customer's. Reliable delivery needs a backend-owned per-turn auto-injection hook, tracked separately in issue #66 since it's a different kind of capability (orchestration hook, not a KV-store contract) and applies to both storage flavors.
zoharbabin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed without merging. This exploration moved to an internal, undecided proposal outside the public repo.