Skip to content

feat(FEC-15050): Compliance Viewing Plugin — real-time unique watched percentage tracking and completion beacon - #225

Open
Tzipi-kaltura wants to merge 3 commits into
masterfrom
FEC-15050
Open

feat(FEC-15050): Compliance Viewing Plugin — real-time unique watched percentage tracking and completion beacon#225
Tzipi-kaltura wants to merge 3 commits into
masterfrom
FEC-15050

Conversation

@Tzipi-kaltura

@Tzipi-kaltura Tzipi-kaltura commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Description of the Changes

Adding new application type - CONTENT_MILESTONE
Adding new events with the above type: video started, video completed it's dispatched from vod-completion plugin.

related to - https://github.com/kaltura/playkit-js-vod-completion/pull/1

solves FEC-15050

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Copilot AI lite review requested due to automatic review settings August 17, 2026 10:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in the Kava plugin for a new application analytics event type (CONTENT_MILESTONE) intended to be emitted by the VOD completion plugin, including optional completion-threshold metadata.

Changes:

  • Introduces ApplicationEventType.CONTENT_MILESTONE and ApplicationFeature.VOD_COMPLETION.
  • Adds VOD completion plugin event constants and maps them into ApplicationEventsModel as content-milestone application events.
  • Extends application-event validation to accept events identified via eventName, and adds an E2E model test for the new event type.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/e2e/application-events.model.spec.js Adds coverage for the new CONTENT_MILESTONE mapping in getApplicationEventsModel.
src/kava.ts Updates application-event validity check to treat eventName as a valid discriminator.
src/enums/application-feature.ts Adds VOD_COMPLETION feature identifier.
src/enums/application-event-type.ts Adds CONTENT_MILESTONE application event type ID.
src/applications-events.ts Defines VOD completion plugin event names and includes them in PluginsEvents.
src/application-events-model.ts Maps the new plugin events to application analytics payloads and adds CONTENT_MILESTONE field handling.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/e2e/application-events.model.spec.js Outdated
Comment thread src/application-events-model.ts Outdated
Comment thread src/application-events-model.ts
Comment thread src/applications-events.ts Outdated
Comment thread src/application-events-model.ts
Comment thread src/application-events-model.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants