feat(FEC-15050): Compliance Viewing Plugin — real-time unique watched percentage tracking and completion beacon - #225
Open
Tzipi-kaltura wants to merge 3 commits into
Open
feat(FEC-15050): Compliance Viewing Plugin — real-time unique watched percentage tracking and completion beacon#225Tzipi-kaltura wants to merge 3 commits into
Tzipi-kaltura wants to merge 3 commits into
Conversation
… percentage tracking and completion beacon
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the Kava plugin for a new application analytics event type (CONTENT_MILESTONE) intended to be emitted by the VOD completion plugin, including optional completion-threshold metadata.
Changes:
- Introduces
ApplicationEventType.CONTENT_MILESTONEandApplicationFeature.VOD_COMPLETION. - Adds VOD completion plugin event constants and maps them into
ApplicationEventsModelas content-milestone application events. - Extends application-event validation to accept events identified via
eventName, and adds an E2E model test for the new event type.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/application-events.model.spec.js | Adds coverage for the new CONTENT_MILESTONE mapping in getApplicationEventsModel. |
| src/kava.ts | Updates application-event validity check to treat eventName as a valid discriminator. |
| src/enums/application-feature.ts | Adds VOD_COMPLETION feature identifier. |
| src/enums/application-event-type.ts | Adds CONTENT_MILESTONE application event type ID. |
| src/applications-events.ts | Defines VOD completion plugin event names and includes them in PluginsEvents. |
| src/application-events-model.ts | Maps the new plugin events to application analytics payloads and adds CONTENT_MILESTONE field handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
roeedean
requested changes
Aug 20, 2026
roeedean
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Adding new application type - CONTENT_MILESTONE
Adding new events with the above type: video started, video completed it's dispatched from vod-completion plugin.
related to - https://github.com/kaltura/playkit-js-vod-completion/pull/1
solves FEC-15050
CheckLists