feat: expand quality badge thresholds and scaffold 2K icon - #1158
Open
LongingForHome wants to merge 1 commit into
Open
feat: expand quality badge thresholds and scaffold 2K icon#1158LongingForHome wants to merge 1 commit into
LongingForHome wants to merge 1 commit into
Conversation
- Lower HD threshold from 1080p to 720p (covers both 720p and 1080p) - Add QHD (1440) boundary; heights >= 1440 && < 2160 fall back to HD badge until a matching quality2k SVG icon is available from design - Add quality2k / quality2kActive entries to BadgeType and icon.scss as a scaffold (SVG paths are placeholders pending design delivery) - 4K threshold unchanged at 2160, 8K unchanged at 4320 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qualityHdbadge now applies to any flavor with height >= 720 (covers both 720p and 1080p), down from the previous 1080-only thresholdquality2kbadge type but currently fall back to the HD badge pending a matching SVG icon from design (see TODO comment ingetLabelBadgeType)quality2k/quality2kActive— entries added toBadgeTypeinicon.tsxand to the$iconsmap and CSS classes inicon.scss; SVG paths are geometric placeholders and should be replaced with final design assets before the 2K branch is activatedTest plan
🤖 Generated with Claude Code