Skip to content

[Triage Fix] SUP-52289: Honor customLabels.audio resolver in AudioMenu - #1164

Open
MosheMaorKaltura wants to merge 2 commits into
masterfrom
SUP-52289
Open

[Triage Fix] SUP-52289: Honor customLabels.audio resolver in AudioMenu#1164
MosheMaorKaltura wants to merge 2 commits into
masterfrom
SUP-52289

Conversation

@MosheMaorKaltura

Copy link
Copy Markdown
Collaborator

Summary

  • Adds support for the customLabels.audio player config resolver in AudioMenu
  • Previously, audio track labels were always resolved as t.label || t.language, ignoring any custom label function configured on the player
  • On mobile the audio flavor overlay is rendered via player.ui.addComponent() (bottom-bar path), where the manifest-provided t.label may differ from desktop; this fix ensures the customer-configured resolver is applied consistently in both rendering paths

Changes

src/components/audio-menu/audio-menu.tsx

  • Read customLabels.audio from props.player.config inside the useMemo that builds audioOptions
  • If the resolver is a function, call it with the track object and use the result as rawLabel (falling back to t.label || t.language)
  • Apply rawLabel to both the visible label and the accessibility ariaLabel
  • Added props.player to the useMemo dependency array

Test plan

  • Verify audio labels render correctly on desktop (no regression)
  • Verify audio labels render correctly on mobile bottom-bar overlay
  • Configure customLabels.audio returning native language names and confirm they appear on both platforms
  • Confirm aria-labels also use the resolved label

🤖 Generated with Claude Code

MosheMaorKaltura and others added 2 commits May 5, 2026 18:11
… rendering

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ioMenu

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant