[Triage Fix] SUP-52289: Honor customLabels.audio resolver in AudioMenu - #1164
Open
MosheMaorKaltura wants to merge 2 commits into
Open
[Triage Fix] SUP-52289: Honor customLabels.audio resolver in AudioMenu#1164MosheMaorKaltura wants to merge 2 commits into
MosheMaorKaltura wants to merge 2 commits into
Conversation
… rendering Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ioMenu Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customLabels.audioplayer config resolver inAudioMenut.label || t.language, ignoring any custom label function configured on the playerplayer.ui.addComponent()(bottom-bar path), where the manifest-providedt.labelmay differ from desktop; this fix ensures the customer-configured resolver is applied consistently in both rendering pathsChanges
src/components/audio-menu/audio-menu.tsxcustomLabels.audiofromprops.player.configinside theuseMemothat buildsaudioOptionsrawLabel(falling back tot.label || t.language)rawLabelto both the visiblelabeland the accessibilityariaLabelprops.playerto theuseMemodependency arrayTest plan
customLabels.audioreturning native language names and confirm they appear on both platforms🤖 Generated with Claude Code