fix(SUP-52316): When you change the caption view on the video and then go back to the video, The settings pop up shows like you are hovering over the button even when you are not. - #1168
Open
inbalvasserman wants to merge 1 commit into
Conversation
…n go back to the video, The settings pop up shows like you are hovering over the button even when you are not.
roeedean
requested changes
May 14, 2026
| if (!this.tooltipElement?.contains(e.target) && this.state.showTooltip) { | ||
| this.hideTooltip(); | ||
| } | ||
| }, 100); |
Contributor
There was a problem hiding this comment.
Did you try to find another way without using setTimeout? Or if you will use 0 instead of 100 will it still be fixed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:
when click on settings so the popup is open, and then click outside of the popup, the popup is closed but then the tooltip of setting is appears
root cause:
when click outside there is an event handler in settings that change the state and cause to focus on the last element and do show for tooltip, on the same time there is event handler in tooltip for click outside that hide the tooltip
solution:
add small delay for the tooltip event handler so first the focus element will be, then hide the tooltip
solved https://kaltura.atlassian.net/browse/SUP-52316