Skip to content

fix(SUP-52316): When you change the caption view on the video and then go back to the video, The settings pop up shows like you are hovering over the button even when you are not. - #1168

Open
inbalvasserman wants to merge 1 commit into
masterfrom
SUP-52316-2

Conversation

@inbalvasserman

Copy link
Copy Markdown
Collaborator

issue:
when click on settings so the popup is open, and then click outside of the popup, the popup is closed but then the tooltip of setting is appears

root cause:
when click outside there is an event handler in settings that change the state and cause to focus on the last element and do show for tooltip, on the same time there is event handler in tooltip for click outside that hide the tooltip

solution:
add small delay for the tooltip event handler so first the focus element will be, then hide the tooltip

solved https://kaltura.atlassian.net/browse/SUP-52316

…n go back to the video, The settings pop up shows like you are hovering over the button even when you are not.
if (!this.tooltipElement?.contains(e.target) && this.state.showTooltip) {
this.hideTooltip();
}
}, 100);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try to find another way without using setTimeout? Or if you will use 0 instead of 100 will it still be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants