fix(FEC-14971): hide audio button when only 'und' language tracks exist - #1178
Open
MosheMaorKaltura with Copilot wants to merge 1 commit into
Open
fix(FEC-14971): hide audio button when only 'und' language tracks exist#1178MosheMaorKaltura with Copilot wants to merge 1 commit into
MosheMaorKaltura with Copilot wants to merge 1 commit into
Conversation
Copilot created this pull request from a session on behalf of
MosheMaorKaltura
June 2, 2026 19:56
View session
MosheMaorKaltura
marked this pull request as ready for review
June 2, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DASH streams with HD flavors produce extra audio tracks with
label:nullthat resolve tolanguage:'und'. The audio button should be hidden when these are the only tracks available.PR #1177 addressed this in
engine-connector.tsxby filtering'und'tracks before updating the store. However, thehasAudioOptionscheck inaudio.tsxstill counted'und'as a valid language:Changes
hasAudioOptionsinsrc/components/audio/audio.tsxto exclude tracks wherelanguage === 'und'and no label is set