Skip to content

fix(FEC-14971): hide audio button when only 'und' language tracks exist - #1178

Open
MosheMaorKaltura with Copilot wants to merge 1 commit into
masterfrom
copilot/fec-14971-code-fix
Open

fix(FEC-14971): hide audio button when only 'und' language tracks exist#1178
MosheMaorKaltura with Copilot wants to merge 1 commit into
masterfrom
copilot/fec-14971-code-fix

Conversation

Copilot AI commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

DASH streams with HD flavors produce extra audio tracks with label:null that resolve to language:'und'. The audio button should be hidden when these are the only tracks available.

PR #1177 addressed this in engine-connector.tsx by filtering 'und' tracks before updating the store. However, the hasAudioOptions check in audio.tsx still counted 'und' as a valid language:

// Before: 'und' passes the t.language check
props.audioTracks?.filter(t => t.label || t.language).length > 1

// After: explicitly exclude 'und'-only tracks
props.audioTracks?.filter(t => t.label || (t.language && t.language !== 'und')).length > 1

Changes

  • Updated hasAudioOptions in src/components/audio/audio.tsx to exclude tracks where language === 'und' and no label is set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants