Use shared OkHttp for playback#140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The app content sync and API calls already used the shared OkHttp client, but playback did not. That meant sync could keep working while the playback network stack went stale and stayed broken until Android force stopped the process.
User Impact
Playback recovery now targets the same networking layer that streams actually use. This should reduce the cases where the library still works but every movie, episode, and live stream stays dead until a force stop.
Verification
GRADLE_USER_HOME=/tmp/gradle ./gradlew :app:testDebugUnitTest