Support datadog metrics submission v2 endpoint #1391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes adding support for version v2 of the metric submission endpoint on the Datadog API reporter. https://docs.datadoghq.com/api/latest/metrics/#submit-metrics
This also makes some other opportunistic changes to the HttpClient class in hopes of making it easier to reason about its logic, and make the reporter configuration more inline with the Span reporter.
My main motivation for these changes was to understand if sending data to that newer Datadog endpoint version has any impact on the sporadic connection timeouts I was seeing while using this reporter (which was also the reason for #1359).
I added a new configuration knob to indicate if one should use the new or old JSON payload format. Not really sure if there is a better way to do this.