Skip to content

Support datadog metrics submission v2 endpoint #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

thyandrecardoso
Copy link
Contributor

This proposes adding support for version v2 of the metric submission endpoint on the Datadog API reporter. https://docs.datadoghq.com/api/latest/metrics/#submit-metrics

This also makes some other opportunistic changes to the HttpClient class in hopes of making it easier to reason about its logic, and make the reporter configuration more inline with the Span reporter.

My main motivation for these changes was to understand if sending data to that newer Datadog endpoint version has any impact on the sporadic connection timeouts I was seeing while using this reporter (which was also the reason for #1359).

I added a new configuration knob to indicate if one should use the new or old JSON payload format. Not really sure if there is a better way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant