feat: wire cache adapter into request path and add cached flag - #11
Merged
Conversation
Apply the configured cache adapter during GET requests instead of silently ignoring it: cache hits skip the network, successful responses populate the cache, and FetchifyResponse gains a required `cached` boolean. TTL is configured via createCacheAdapter's new optional `cacheTtlMs`, kept as the single place to control expiry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sync the cache-adapters and http-client delta specs into the main specs, and move the completed change into openspec/changes/archive/. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createFetchifynow actually uses the configuredcacheadapter:GETrequests check the cache before hitting the network, and successful (ok)GETresponses are written back, keyed by method + resolved URL. Non-GETrequests and non-ok responses never touch the cache.FetchifyResponse<T>gains a requiredcached: booleanfield (BREAKING).createCacheAdapteraccepts an optional secondoptions: { cacheTtlMs?: number }argument to set a default TTL applied tosetcalls that omit one; an explicitttlMsonsetalways wins. TTL is configured only at the adapter — not onFetchifyOptions.Test plan
bun test(51 tests pass)bun run linttsc --noEmitmajor, breakingcachedfield)apply-cache-mechanismimplemented, spec deltas synced intoopenspec/specs/cache-adaptersandopenspec/specs/http-client, and archived🤖 Generated with Claude Code