feat: move boards between workspaces

[nickmeinhold]

Summary

Adds the ability to move a board (and all its contents) from one workspace to another. Closes #344.

• New board.move API mutation with dual permission checks (source + target workspace)
• "Move to workspace" menu item in the board dropdown
• Workspace picker modal with warning about card member clearing
• Auto-resolves slug conflicts in the target workspace by appending a UID suffix

Design decisions

Per @hjball's comment about handling comments, activity, and assignees:

Entity	References	Workspace-scoped?	Behaviour on move
Card assignees	workspaceMembers.id	Yes	Cleared — these reference workspace-scoped member IDs that may not exist in the target workspace. User sees a warning before confirming.
Comments	users.id	No	Preserved — comments reference the global user UUID, not workspace membership. They'll display correctly even if the author isn't a member of the target workspace.
Activity log	users.id	No	Preserved — same as comments, activity entries reference global user IDs. Full history is retained.

Permission model

• Requires board:edit permission (or creator) in the source workspace
• Requires board:create permission in the target workspace
• Templates and archived boards cannot be moved

What moves

Everything: lists, cards, labels, checklists, checklist items, comments, activity, attachments. All of these reference the board (directly or transitively), not the workspace — so updating board.workspaceId is sufficient.

What gets cleared

Only _card_workspace_members entries (card assignees), because they join through workspace-scoped member IDs. Users can reassign cards after the move.

Files changed

• packages/db/src/repository/board.repo.ts — moveToWorkspace() transactional function
• packages/api/src/routers/board.ts — board.move mutation
• apps/web/src/views/board/components/BoardDropdown.tsx — menu item
• apps/web/src/views/board/components/MoveBoardForm.tsx — new component
• apps/web/src/views/board/index.tsx — modal registration
• apps/web/src/locales/ — extracted + compiled translations

Test plan

• Move a board between workspaces — verify board appears in target, disappears from source
• Verify card member assignments are cleared after move
• Verify comments and activity history are preserved
• Test slug conflict: create boards with same name in both workspaces, move one
• Verify templates cannot be moved (menu item hidden)
• Verify archived boards show error message
• Verify user without board:create in target workspace cannot move

🤖 Generated with Claude Code

[nickmeinhold]

Automated Code Review — Cage Match Edition

Two AI reviewers independently analyzed this PR:

---

MaxwellMergeSlam's Review 🤼

Verdict: APPROVE

Summary: A clean, well-architected feature that moves boards between workspaces with proper permission gates and data integrity — this PR gets it done without breaking a sweat.

Tyler Durden: "It's only after we've lost everything that we're free to do anything." And it's only after we've properly cleared workspace-scoped card assignments that we're free to move a board anywhere.

Findings:

• board.repo.ts:moveToWorkspace — The transactional approach is correct. Updates workspaceId, then walks the boards → lists → cards → _card_workspace_members chain to clear orphaned assignments. Two SELECT queries inside the transaction (lists, then cards) before the DELETE is clean and readable.

• board.ts:move mutation — Dual permission model (assertCanEdit on source, assertPermission("board:create") on target) is the right call. Template and archive guards are present. Slug conflict auto-resolution via generateUID() suffix matches the existing pattern used in board.create.

• board.ts:~line 680 — There's a secondary query to fetch boardDetails.slug using ctx.db.query.boards.findFirst() inline rather than through the repo layer. This works but breaks the pattern slightly — every other board query in this file goes through boardRepo. Minor consistency nit, not a blocker.

• MoveBoardForm.tsx — Clean component. Uses switchWorkspace() on success to redirect the user to the target workspace's boards page, which is good UX. The "no other workspaces" empty state is handled. Warning text about member clearing is present.

• MoveBoardForm.tsx:27 — availableWorkspaces is filtered by publicId to exclude the current workspace. But there's no filtering for permission — a user might see workspaces where they're a guest without board:create permission. The server will reject it (permission check is in the mutation), so this isn't a security issue — but it's a minor UX annoyance (user selects workspace, gets error). Could filter by role !== "guest" client-side as a heuristic.

• BoardDropdown.tsx — Menu item placement is logical: after archive, before favorites. Gated on !isTemplate && canEditBoard. The HiArrowRightOnRectangle icon is a reasonable choice.

The Good:

• The PR description is chef's kiss — the entity reference table showing what's workspace-scoped vs global is exactly what a reviewer needs. Henry shouldn't have to dig through schema files to understand the design.
• Transaction in the repo layer keeps the mutation atomic.
• Follows every existing pattern: permission helpers, repo functions, modal system, Lingui translations, conventional commit message.
• Net new code is ~190 lines (excluding locale files). Tight.

The Concerns:

• Minor UX: Guest users might see workspaces they can't move to in the dropdown. Server rejects it safely, but an error popup for a predictable case isn't ideal.
• Minor consistency: The inline ctx.db.query.boards.findFirst() in the mutation should ideally go through the repo layer.
• No tests: There are no new unit/integration tests for board.move or moveToWorkspace. The existing helpers.test.ts pattern shows tests are valued in this codebase. Not blocking for a first pass, but would strengthen confidence.

Neo: "I know kung fu." This PR knows its schema. APPROVE.

---

KelvinBitBrawler's Review

Verdict: REQUEST_CHANGES

Summary: This PR introduces a functional board movement feature, complete with proper permission checks and transactional integrity, but suffers from thermal inefficiency and a frosty oversight in slug generation.

Findings:

• packages/api/src/routers/board.ts: L658, L667, L707 - Multiple, redundant database queries are executed to retrieve board information (workspaceId, type, isArchived, slug). This is a gross thermal inefficiency. You're hitting the database repeatedly when a single, well-structured query could pull all necessary data. HAL 9000: "I am putting myself to the fullest possible use, which is all I think that any conscious entity can ever hope to do." Your code isn't.
• packages/api/src/routers/board.ts: L712 - The fallback for slug generation generateSlug(input.boardPublicId) is utterly devoid of human sense. Slugs are meant to be readable identifiers, not a raw public ID. If the original board slug is missing, you should be deriving it from the board's name, not some cryptic identifier. This will result in an unreadable slug, and that's just poor form, a literal cold shoulder to user experience.

The Good:

• packages/db/src/repository/board.repo.ts: L963-L1017 - The moveToWorkspace function is wrapped in a db.transaction, ensuring atomicity. This cold, hard transactional integrity is precisely what's needed for data consistency. Good.
• packages/api/src/routers/board.ts: L680, L700 - Permission checks for both the source (board:edit) and target (board:create) workspaces are explicitly handled and correctly enforced. Zero tolerance for unauthorized access.
• packages/api/src/routers/board.ts: L714-L716 - Automated slug conflict resolution by appending a UID suffix is a practical and robust solution to prevent data collisions. No icy stalemates there.
• apps/web/src/views/board/components/MoveBoardForm.tsx: L25, L31 - Clear user feedback with success and error popups, and the explicit warning about clearing card member assignments, shows a consideration for the end-user. It's not a complete deep freeze, but it's a good step.

The Concerns:

• The redundant database calls in packages/api/src/routers/board.ts must be refactored into a single, comprehensive query. This isn't just about performance; it's about not writing unnecessary boilerplate that obscures intent. Deckard: "Gifts for the boss, huh?" You're bringing too many separate gifts to the same table.
• The generateSlug(input.boardPublicId) fallback needs to be reconsidered. If boardDetails?.slug is null, the system should retrieve the board's name to generate a meaningful slug, rather than using the publicId. This is a basic expectation for user-friendly URLs.

---

Consensus & Resolution

Maxwell: APPROVE | Kelvin: REQUEST_CHANGES

Kelvin caught two valid issues that Maxwell missed:

1. Redundant DB queries — 3 separate queries for the same board consolidated into 1
2. Slug fallback — generateSlug(input.boardPublicId) changed to generateSlug(board.name) for readable URLs

Both fixes addressed in commit 2c2a349.

[nickmeinhold]

Hey @hjball — heads up, the diff stats on this PR look scary (50k+ lines) but that's almost entirely auto-generated locale files (18 of 24 changed files).

I've added a .gitattributes file that marks those as linguist-generated, so GitHub should now auto-collapse them in the diff view. The actual feature code is just 6 files:

• packages/db/src/repository/board.repo.ts — repo function for the move
• packages/api/src/routers/board.ts — board.move mutation
• packages/api/src/routers/board-move.test.ts — tests
• apps/web/src/views/board/components/BoardDropdown.tsx — menu item
• apps/web/src/views/board/components/MoveBoardForm.tsx — workspace picker modal
• apps/web/src/views/board/index.tsx — modal registration

[hjball]

This is great @nickmeinhold - please could you remove the locale changes from this PR (it's all handled automatically on merge now)

[hjball]

This should be good to go after the locale changes have been removed

[nickmeinhold]

Locale file changes removed — the PR diff is now just the feature code (20 files, ~1.7k lines). Ready for another look when you get a chance!

[hjball]

Can we use the existing getBoardbyPublicId func instead? That should already filter out deletedAt records

[nickmeinhold]

Good catch — getByPublicId is the wrong shape here (it pulls the full board with cards/labels/joins for the board-detail view). I kept getBoardForMove because it has the right column projection for this flow, and added the isNull(deletedAt) filter inline. Same effect: tombstoned boards now return null.

[hjball]

We should probably check this doesn't return deleted records too

[nickmeinhold]

Done — guarded at the call site. workspaceRepo.getByPublicId doesn't filter deletedAt (legacy: same is true for ~14 other callers across workspace.ts, member.ts, webhook.ts, etc.). Extended its column projection to include deletedAt and added || targetWorkspace.deletedAt to the guard. The wider fix to make the repo treat deleted-as-not-found across all callers is a separate concern — happy to follow up in another PR if you'd prefer that pattern globally.

[hjball]

We'll want to include all cards (even those already deleted) so we don't have rouge members assignments when restoring cards in future

[nickmeinhold]

Right, that's the rogue-restore case. Removed the isNull(deletedAt) filters on both the lists query and the cards query in this loop, so member assignments are now cleared for every card under every list ever associated with this board — soft-deleted or not. Added a regression test for the soft-deleted target workspace path while in the area (board-move.test.ts now has 11 tests, all passing).

[hjball]

Looking great @nickmeinhold - just a few small comments to address otherwise this one lgtm

[nickmeinhold]

Thanks @hjball — locale changes removed in 4f11ed4 (re-aligned to upstream/main since the earlier removal had used a stale local main). PR's Files changed should now be free of locale/i18n diffs. Ready for another look.

[hjball]

Hey @nickmeinhold, couple of bits needed before we can merge this:

• Looks like the locale changes have snuck back in
• There's a couple of comments that need addressing

[nickmeinhold]

@hjball — all three comments addressed in 272011d, plus a regression test for the soft-deleted target workspace case (board-move.test.ts now has 11 tests, all passing). Also merged latest upstream/main to clear conflicts. Ready for another look when you have a moment 🙏

[nickmeinhold]

Conflicts resolved and CI is green again. The PR went stale purely from upstream drift (main moved ~32 commits ahead with the partner/Stripe/subscriptions work), not from anything outstanding on the review.

Merged latest main:

• All locale/i18n conflicts resolved by taking main's version, so the locale files are dropped from the diff entirely (verified: git diff main -- locales/ is empty). Files changed is back to just the 7 feature files.
• One real code conflict in workspace.repo.ts: main added createdBy to the getByPublicId select while this branch added deletedAt (for the soft-delete guard). Kept both.

11/11 board-move tests passing, @kan/db and @kan/api typecheck clean, build check green. Ready for another look when you get a chance.