Skip to content

Add github-webhook-plus plugin entry#563

Merged
fguillot merged 1 commit intokanboard:mainfrom
y9938:chore/update-github-webhook-v1.1.1
Apr 25, 2026
Merged

Add github-webhook-plus plugin entry#563
fguillot merged 1 commit intokanboard:mainfrom
y9938:chore/update-github-webhook-v1.1.1

Conversation

@y9938
Copy link
Copy Markdown
Contributor

@y9938 y9938 commented Apr 1, 2026

Update plugin metadata.

Copy link
Copy Markdown
Member

@fguillot fguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a maintained fork, please publish it under a new plugin name instead of changing the ownership from kanboard/plugin-github-webhook to y9938/plugin-github-webhook.

Changing the download source effectively turns this into a supply-chain trust handoff. Using a new name makes the fork explicit and allows users to opt in intentionally.

@y9938 y9938 changed the title Update plugins.json (github-webhook v1.1.1) Add github-webhook-plus plugin entry Apr 23, 2026
@y9938
Copy link
Copy Markdown
Contributor Author

y9938 commented Apr 23, 2026

@fguillot Should I send a new PR using a different branch name?

@y9938 y9938 force-pushed the chore/update-github-webhook-v1.1.1 branch from 8b1047c to 122a43e Compare April 24, 2026 00:06
@y9938
Copy link
Copy Markdown
Contributor Author

y9938 commented Apr 24, 2026

@fguillot I've rebranded the fork and the release zip archive now has a different name. I kept your authorship in plugins.json since this is a fork of your original repository — I made it to keep the plugin compatible with newer Kanboard versions and add some improvements. I've rebased this branch, squashing it down to a single commit that only adds the new plugin entry at the end of plugins.json.

@y9938 y9938 requested a review from fguillot April 24, 2026 00:27
@fguillot
Copy link
Copy Markdown
Member

There is a validation failure: https://github.com/kanboard/website/actions/runs/24865166641/job/72964575577?pr=563

Dictionary is not alphabetically ordered:

  • Violation at : 'zulip' should come after 'github-webhook-plus'

@y9938 y9938 force-pushed the chore/update-github-webhook-v1.1.1 branch from 122a43e to 1d78238 Compare April 25, 2026 00:29
@y9938
Copy link
Copy Markdown
Contributor Author

y9938 commented Apr 25, 2026

Now python3 scripts/validate-plugins.py passes. The branch contains one clean commit.

@fguillot fguillot merged commit 4652553 into kanboard:main Apr 25, 2026
1 check passed
@y9938 y9938 deleted the chore/update-github-webhook-v1.1.1 branch April 26, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants