-
-
Notifications
You must be signed in to change notification settings - Fork 152
Monorepofication and pnpmping out. #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… (.npmrc, .gitignore, scripts)
|
Thank you so much for looking into this! As soon as I find the time, I'll look into this. I'm currently busy preparing a bugfix release which will address some pressing issues, but then I hope to find the time to discuss this in detail! |
|
You're welcome, I'm glad to help, and these first steps will make collaboration and building on top of Kando easier! I am fiddling around to get the ci/cd github actions working now. |
|
This looks really good! I think it's a great starting point to make Kando much more versatile in terms of potential applications. The only thing I needed to change to make this working was to add the following to onlyBuiltDependencies:
- '@parcel/watcher'
- electron
- electron-winstaller
- esbuildHow are the imports from @kando/core working? I mean it seems to work, but I do not see this mentioned as a dependency. If I add Anyways, now I wonder... How to proceed? I guess a lot needs to be tested and tweaked. Things which come to my mind:
What do you think? Should we maybe merge this to a separate branch and get it working there with smaller PRs? Then we can focus on individual tasks and merge it only to |
Monorepo setup with pnpm; move Electron app to apps/kando; add skeleton packages
Summary
Changes
What did not change
How to run
Follow-ups (separate PRs)
Review focus