Skip to content

fixes: STATIC_URL is hardcoded in read-view & nginx.conf (docker)#48

Open
s3h10r wants to merge 3 commits intokanishka-linux:masterfrom
s3h10r:patch-static_url
Open

fixes: STATIC_URL is hardcoded in read-view & nginx.conf (docker)#48
s3h10r wants to merge 3 commits intokanishka-linux:masterfrom
s3h10r:patch-static_url

Conversation

@s3h10r
Copy link
Contributor

@s3h10r s3h10r commented Jun 1, 2020

Hi,
the STATIC_URL is hardcoded in nginx.conf and the custom-read.py. It would be helpfull to be able to configure the STATIC_URL to something different than /static/ through the whole stack (the app-container and the nginx-container - without touching 2 different files).

For illustrations: I am using Apache's SSLProxyEngine to masquerade different internal docker-/app-containers via a public URL like in the following (/reminiscence_static/ is for the static-files served by the nginx-container, /reminiscence/ represents the ROOT_URL_LOCATION of Reminiscence and leads to the web-container here, the /static/-URL instead is use for another app running on the same server/virtual-host entry):

    SSLProxyEngine On

    ProxyPass /reminiscence/ http://n.n.n.n:8100/reminiscence/
    ProxyPassReverse /reminiscence/ http://n.n.n.n:8100/reminiscence/
    ProxyPass /reminiscence_static/ http://n.n.n.n:8100/reminiscence_static/
    ProxyPassReverse /reminiscence_static/ http://n.n.n.n:8100/reminiscence_static/

This patch adresses this.

Greetings,
Sven

@kanishka-linux
Copy link
Owner

Hey thanks, I'll surely look into it in the weekends

@kanishka-linux
Copy link
Owner

As these are code changes, won't it be better to have some tests around these changes?

@s3h10r
Copy link
Contributor Author

s3h10r commented Jun 8, 2020

Hi, sure. Don't have time at the moment but will look into writing tests for it. Greetings, Sven

@s3h10r s3h10r force-pushed the patch-static_url branch from 675d088 to d4cefcc Compare July 3, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants