Feat (WIP): Backend-Based Filters for Backgrounds#889
Open
leherkom wants to merge 4 commits intokanriapp:mainfrom
Open
Feat (WIP): Backend-Based Filters for Backgrounds#889leherkom wants to merge 4 commits intokanriapp:mainfrom
leherkom wants to merge 4 commits intokanriapp:mainfrom
Conversation
Collaborator
|
Small update on my end: as part of the current rewrite going on I'm planning to add background image logic into a composable useBackgroundImage and potentially a separate component that will be responsible for rendering the background and keeping track of the values. Since the rewrite is currently taking a bit longer than expected, until some other critical aspects are done this is postponed by a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
New Feature Submissions:
Please describe your changes
PoC for a new, more stable way to filter background images. This method uses Rust to decrease the brightness and add the blur on the background image and write out a filtered copy. The copy can then be used as the image source for the Kanban boards.
Uses additional storage space for saving the copy, but ensures that the backgrounds always look the same on all devices. The filters no longer rely on CSS filters applying correctly.
Overview of the general idea:
Additional context
TODOs
Considerations
CustomBackground.vue:Then open the dialog and move the brightness slider. The filtered image is not yet displayed as the background of the board, but the result can be checked out in the file explorer.