Conversation
|
Thanks for your PR! Will review it and get back to you soon. |
|
Hi! Thanks again for your contribution. I've taken a look at the code and tested the feature, and it seems to work great. Just one nitpick on the UX-side: could you maybe highlight the keywords Once that's added, the PR is ready to merge :) |
|
Hi, any updates on this PR? Once the UX issue I've addressed above is solved this PR would be ready to merge. |
|
I started an internship not long after opening this so I haven't been quite as active, I'll see when I can find time |
|
No worries at all, take your time. And congrats on the internship :) |
Pull request
New Feature Submissions:
Changes to Core Features:
Please describe your changes
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature:
Introduces sorting by tags and dueDate.
Describe what your code exactly does and if it affects any other part of the code in any way (especially check for breaking changes)
Adds a "sort:" filter to the search bar, which accepts a comma-separated list of a permutation of any size from {"tags", "dueDate"}, where earlier fields have precedence. If there are multiple tags per card, they are sorted lexicographically. dueDates are sorted as such: lesser dueDate, greater dueDate, null dueDate, completed lesser dueDate, completed greater dueDate.
Additional context
Since I mostly created this for self use, I haven't yet implemented additional features (directionality, other fields) as I am indifferent to the details of their implementation.