Explicitly require jquery in kanso. Fixes kanso/db#12.#13
Open
mgmarino wants to merge 1 commit intokanso:masterfrom
Open
Explicitly require jquery in kanso. Fixes kanso/db#12.#13mgmarino wants to merge 1 commit intokanso:masterfrom
mgmarino wants to merge 1 commit intokanso:masterfrom
Conversation
The jquery dependency is now explicitly included through require.
|
I'm wondering, why this pull request is not accepted yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jquery dependency is now explicitly included through require.
This is the "lightest" solution to the hidden dependency on jQuery in that it changes the smallest of code. It however does require the user to use jQuery through the kanso distribution.