将 String 和 Number 接口都合并到 Object 中#6
Open
xserver wants to merge 5 commits into
Open
Conversation
Member
|
@xserver 抱歉回复晚了,你的这个pull request我当时看了后很犹豫,所以一直没有想好是否应该merge过来。,我认为你的这种写法是有一些好处的。如果是新应用这么写还是不错的。但主要的问题是,你的这个存储方案改了存储逻辑,那么会造成历史数据无法读取,而我们的线上应用都依赖了这个库,如果我接受这个pull request,我需要另外写相关的数据转换逻辑。否则用户的历史数据都丢了,这是不可接受的。 所以我可能现在无法merge你的请求。非常抱歉。。。。 另外提个小意见,不要的代码可以直接删掉,不用注释掉,注释掉还是挺不干净的。 |
Author
|
@tangqiaoboy 的确如此,Good Luck. 刚玩 Git ,貌似有历史对比功能,删掉的确比较好。Cool. thank you. |
|
支持合并的建议,现在的接口putObject和putString等不是一个level的,可以做一个release版本保存现有状态,新版用合并后的接口 |
|
@xserver @tangqiaoboy @boydc2014 我在swift版中在保留数据库结构的情况下对string和number接口进行了整合,可以看一下: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1、在表中添加 type 字段记录类型;
2、putObject 判断类型,都抽象为 String 入库;
3、取出时,判断type,转换为相应类型;