Skip to content

Fork Sync: Update from parent repository #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 342 commits into
base: master
Choose a base branch
from

Conversation

kaovilai
Copy link
Owner

No description provided.

mateusoliveira43 and others added 30 commits October 5, 2023 00:22
* fix: OADP-2747 Re-enable DataMover E2E tests

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2747 Re-enable DataMover E2E tests

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2747 Re-enable DataMover E2E tests

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2747 Re-enable DataMover E2E tests

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2747 Re-enable DataMover E2E tests

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
SanitizeHostForHeader puts the stripped host name into the Host field of
the HTTP request, but only if it actually needed to strip the port. If
there is already no port, that Host field can be blank, and there is no
reason to overwrite the URL's host field.

Signed-off-by: Matthew Arnold <[email protected]>
Performance team noticed some errors while running
Kopia that did not have any impact backups or restores
)

Adds kopia to the e2e tests and inclues some renaming to be consistent
with nodeagent convention.

Some of the left over functions will be deprecated in 1.4.

Signed-off-by: Michal Pryc <[email protected]>
To deploy sample application:
 $ oc create ns mongo-persistent
 $ oc apply -f pvc/default_sc-block-mode.yaml
 $ oc apply -f mongo-persistent-block.yaml

Signed-off-by: Michal Pryc <[email protected]>
…over (#1171)

* fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP-2767 Remove references to VSM/Volsync DataMover

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
* fix: make test command succeeds locally

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: make test command succeeds locally

Signed-off-by: Mateus Oliveira <[email protected]>

* Update config/manifests/bases/oadp-operator.clusterserviceversion.yaml

Co-authored-by: Tiger Kaovilai <[email protected]>

* fixup! fix: make test command succeeds locally

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: make test command succeeds locally

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: make test command succeeds locally

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
Co-authored-by: Tiger Kaovilai <[email protected]>
* Update OADP Readme to point to proper product docs

* update to latest vs. versioned url

* remove duplicate link to production docs

* update the text for the official doc

* Update README.md

Co-authored-by: Tiger Kaovilai <[email protected]>

* fix TOC link

---------

Co-authored-by: Tiger Kaovilai <[email protected]>
* WIP: Update the upgrade instructions

* make things a little cleaner, easier to read

* address comments

* address addtional comments

* update yaml format

* vsc label is still required
Adds missing descriptions to the following CRDs:

 - DataDownload
 - DataUpload
 - VolumeSnapshotBackup
 - VolumeSnapshotRestore
 - CloudStorage

Signed-off-by: Michal Pryc <[email protected]>
Since VSB and VSR is not needed in OADP 1.3+ removing it from the CSV.

Updated API_ref and script to not show errors. E.g. when the ocp is missing
those APIs, however left the functions in the datamover_resources.sh as one
may want to run it against earlier OADP versions.
* fix: One kubernetes client per E2E suite run

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: One kubernetes client per E2E suite run

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: One kubernetes client per E2E suite run

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: One kubernetes client per E2E suite run

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
* fix: Refactor and removal of dupliucations in E2E tests

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: Refactor and removal of dupliucations in E2E tests

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
* doc: How to update OCP version jobs in CI

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! doc: How to update OCP version jobs in CI

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! doc: How to update OCP version jobs in CI

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
Signed-off-by: Mateus Oliveira <[email protected]>
* WIP: first pass at an updated OADP-1.3.0 DM blog post

* updates to the dm flow

* add the backup simple workflow

* fix title

* update the transcribed workflow of dm backup

* organize and update for restore

* update status section

* updates for restore and blockMode

* add block restore

* update to incorporate David's comments

* fix nits and url for Scott's review

* fix search and replace error

* update for Shubhams review

* updates for readability
* Indicate to user a new vsc def is required

* update from comments

* updates storage class clarity
* fix: Fix codecov post job

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: Fix codecov post job

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
sseago and others added 30 commits March 17, 2025 20:26
* Add logFormat to the DPA's velero config

Fixes OADP-3391

Signed-off-by: Michal Pryc <[email protected]>

* Move LogFormat to the top level spec

Make LokFormat available for all the parts:
 spec:
   logFormat: json
   configuration:
     nodeAgent:
     velero:
   nonAdmin:

Signed-off-by: Michal Pryc <[email protected]>

---------

Signed-off-by: Michal Pryc <[email protected]>
* Add disableFsBackup config to DPA for enhanced security for the node-agent

Fixes:
 OADP-5033
 OADP-5104
  - With default to be permissive (FSBackup working)
 OADP-5105
  - With default to be permissive (FSBackup working)

Partial fix for:
 OADP-5031
  - need to address doc and sample apps
 OADP-5141 - todo: address datamover
 OADP-5182 - todo: address datamover

This change
 - adds new disableFsBackup option to the DPA/velero Spec
 - Modifies that the node-agent is always ran as non-root user
 - Changes the root filesystem to be read only !
 - Makes two mountpoints writeable:
   /home/velero
   /tmp/credentials
 - Uses SeccompProfileTypeRuntimeDefault for the SeccompProfile

With the disableFsBackup set to false or non-existing,
the following options are added to the SecurityContext:
 - Privileged: true
 - AllowPrivilegeEscalation: true

With disableFsBackup flag to set to true:
 - Removes the following mounts from the node-agent:
   host-pods
   host-plugins

Signed-off-by: Michal Pryc <[email protected]>

* Refactor function to have less privileged conditions

Refactor of function to have less privileged conditions
to make it more readable.

It contains same logic as before.

Signed-off-by: Michal Pryc <[email protected]>

* Run as root user when FS backup is enabled

Signed-off-by: Michal Pryc <[email protected]>

* Ensure /tmp is read-write

For the proper node-agent operations the /tmp folder
needs to be read/write.

Signed-off-by: Michal Pryc <[email protected]>

---------

Signed-off-by: Michal Pryc <[email protected]>
* Fix for Improve DPA additionalPrinterColumns #1659

* run make build to generate yaml files

---------

Co-authored-by: hariprakash619 <[email protected]>
Uses fix from OADP-3391
Fixes 4408

Signed-off-by: Michal Pryc <[email protected]>
…1648)

Implements #232 with additional fields for:
 - NonAdminBackup
 - NonAdminRestore
 - NonAdminBackupStorageLocation

Signed-off-by: Michal Pryc <[email protected]>
* Add option to use ConfigMap in the node agent

Fixes OADP-5042, add ConfigMap to the NodeAgent

Signed-off-by: Michal Pryc <[email protected]>

* Use node-agent CM node Affinity from the PodConfig

1. Use PodConfig node Affinity for the CM used in node agent
2. Added test coverage for the new CM

Signed-off-by: Michal Pryc <[email protected]>

* Fix CM creation error from the e2e tests

The error was due to refactor of updateNodeAgentCM function
and the name/namespace of CM was empty.

Signed-off-by: Michal Pryc <[email protected]>

* Ensure node-agent restarts when the CM gets updated

Node Agent pods will restart when the CM will get updated.

Signed-off-by: Michal Pryc <[email protected]>

* Ignore not found error

Review nit.

Signed-off-by: Michal Pryc <[email protected]>

* Add better test example for the backupPVC

Replace current confusing pvc with the proper
storage class config sample.

Signed-off-by: Michal Pryc <[email protected]>

---------

Signed-off-by: Michal Pryc <[email protected]>
Fixes OADP-5275 which ensures the controller manager
has readOnlyRootFilesystem set to true.

Signed-off-by: Michal Pryc <[email protected]>
Signed-off-by: Mateus Oliveira <[email protected]>
* first pass at updating OADP versions

* typo

* typo1

* Update PARTNERS.md

Co-authored-by: RayfordJ <[email protected]>

* updates from reviews

* update timelines

* update w/ sequence diagrams

* add mermaid type

* corrections from Rayford's comments

* remove dpa error on 1.4

---------

Co-authored-by: RayfordJ <[email protected]>
* fix: OADP must-gather refactor

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP must-gather refactor

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP must-gather refactor

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP must-gather refactor

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP must-gather refactor

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: OADP must-gather refactor

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
…1672)

* Validate secret content in validator for parsing errors

 to block bsl creation if secret parsing would fail in later steps.

Signed-off-by: Tiger Kaovilai <[email protected]>

* refactor

Signed-off-by: Tiger Kaovilai <[email protected]>

* address comments

Signed-off-by: Tiger Kaovilai <[email protected]>

---------

Signed-off-by: Tiger Kaovilai <[email protected]>
Remove velero-restore-helper image references and
delete fs-restore-action-config configmap if present.
* fix: validate upgrade to 1.5

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: validate upgrade to 1.5

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fixup! fix: validate upgrade to 1.5

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: validate upgrade to 1.5

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
* fix: NAC CI

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: NAC CI

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
…t and DataMover (#1683)

* Node Selector Configuration for Data Protection Components

This proposal introduces a standardized approach for configuring
node selectors in the DataProtectionApplication (DPA)
custom resource for various use cases that are common
across different Velero settings.

Fixes: OADP-5832

Signed-off-by: Michal Pryc <[email protected]>

* Update design to not cover Velero pod in the current implementation

The Velero pod uses node selector and should be sufficient for most
cases, because there is only one pod scheduled and as such user have
1-1 mapping with the node label on which the pod is scheduled.

Signed-off-by: Michal Pryc <[email protected]>

* Update podConfig and loadAffinity to ensure proper scheduling

In this update we ensure the nodeSelector within podConfig is scheduled
in less restricted way then the loadAffinity, ensuring the DataMover
pods will get scheduled on the nodes where node-agents are running.

This corner case was when user used both settings and used different
labels between podConfig and loadAffinity.

The loadAffinity must be a subset of what's defined in the podConfig.

Signed-off-by: Michal Pryc <[email protected]>

---------

Signed-off-by: Michal Pryc <[email protected]>
Signed-off-by: Michal Pryc <[email protected]>
* Add design for DataProtectionTest CRD and Controller

minor fix

* remove DPA integration and add support for multiple CSI VS

* fix typos

* add duration, bucket metadata support: encyrption and versioning status

* Remove BSL NS Ref, just use name
to configure repository maintenance via DPA that is then
translated to the CM used by the Velero deployment.

The detailed design is in the OADP-5832 PR.

Signed-off-by: Michal Pryc <[email protected]>
* fix: backport compatibility must-gather

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: backport compatibility must-gather

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.