Update existing events instead of replacing them #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why this is not reviewed yet? This is such a important feature. +1 to this. |
|
+1 on this. Please add a co-mainter for this project. |
mmurshed
approved these changes
Jul 27, 2022
mmurshed
suggested changes
Jul 27, 2022
| method: 'PUT', | ||
| endpoint: `${ENDPOINT_BASE}/${CALENDAR_TO_MERGE_INTO}/events/${target_event.id}`, | ||
| requestBody: { | ||
| summary: `${SEARCH_CHARACTER}${source_event.summary} ${calendarName}`, |
There was a problem hiding this comment.
Can you please move this prefix calendarName to the beginning like the main code does?
| method: 'POST', | ||
| endpoint: `${ENDPOINT_BASE}/${CALENDAR_TO_MERGE_INTO}/events`, | ||
| requestBody: { | ||
| summary: `${SEARCH_CHARACTER}${source_event.summary} ${calendarName}`, |
There was a problem hiding this comment.
If the PUT call create a calendar with name "Test [Work]", will the POST for update it to "Test [Work] [Work]"? Looks like a bug.
| // Only consider events that are not "free". | ||
| if (source_event.transparency !== 'transparent') { | ||
|
|
||
| const target_event = target_events.filter((candidate_event) => (candidate_event.iCalUID == source_event.iCalUID))[0]; |
There was a problem hiding this comment.
Should it be candidate_event.iCalUID === source_event.iCalUID? What if candidate_event is null?
| } | ||
|
|
||
| console.log(`${result.length} deleted events.`); | ||
| console.log(`${result.length} events ${action}d.`); |
|
We also need a force delete option. |
mmurshed
reviewed
Jul 27, 2022
| // check if target event exists and update it if it does. if not, then create it. | ||
| requestBody_update = [] | ||
| requestBody_create = [] | ||
| let new_description = "" |
Author
|
I will fix the issues you found as soon as I find some time! Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does what I've described in issue #14