Skip to content

Fixes #56 ; Don't attempt to set Content-Type header if the request is using multipart-formdata #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

grantyb
Copy link
Contributor

@grantyb grantyb commented May 4, 2025

I have tested this for both typescript-fetch-client and typescript-fetch-client2

@@ -125,6 +125,7 @@ export const {{className name}}ApiFetchParamCreator = function (configuration?:

{{/if}}
{{#with requestBody}}
{{#ifeq (isContentMultipart defaultContent) false}}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use not instead of ifeq false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a few iterations. There's no not usage anywhere I can see. Is {{#unless}} the thing I want?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used {{#unless}}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants