Fixes #56 ; Don't attempt to set Content-Type header if the request is using multipart-formdata #57
+30
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest is using multipart-formdata
karlvr
requested changes
May 4, 2025
| @@ -125,6 +125,7 @@ export const {{className name}}ApiFetchParamCreator = function (configuration?: | |||
|
|
|||
| {{/if}} | |||
| {{#with requestBody}} | |||
| {{#ifeq (isContentMultipart defaultContent) false}} | |||
There was a problem hiding this comment.
I think we could use not instead of ifeq false
There was a problem hiding this comment.
I tried a few iterations. There's no not usage anywhere I can see. Is {{#unless}} the thing I want?
There was a problem hiding this comment.
I've used {{#unless}}.
… of {{#ifeq (isContentMultipart defaultContent) false}}
… will consume multipart/form-data
… to add the MultipartProvider so we can parse the params
…t should deserialize them.
…od to discern if an endpoint consumes multipart/* as `isContentMultipart()`
…ore type-safe, consistent and correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested this for both typescript-fetch-client and typescript-fetch-client2