build(deps): bump react and types/react in /ui #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
dependencies
karmada-bot
added
the
do-not-merge/invalid-commit-message
karmada-bot
added
the
size/XL
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/ui/multi-e1aa4930cf
branch
from
aaa56be to
fd98caa
Compare
Member
|
/retitle build(deps): bump react and types/react in /ui |
karmada-bot
changed the title
Signed-off-by: dependabot[bot] <[email protected]>
RainbowMango
force-pushed
the
dependabot/npm_and_yarn/ui/multi-e1aa4930cf
branch
from
fd98caa to
3eaccaf
Compare
karmada-bot
removed
the
do-not-merge/invalid-commit-message
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
https://react.dev/learn/typescript#children Signed-off-by: RainbowMango <[email protected]>
Collaborator
|
New changes are detected. LGTM label has been removed. |
| interface LangConfig { | ||
| title: string; | ||
| icon: JSX.Element; | ||
| icon: ReactNode; |
Member
There was a problem hiding this comment.
This is for fixing the build error error TS2694: Namespace 'global.JSX' has no exported member 'Element'. As per https://react.dev/learn/typescript#children.
Error: src/utils/i18n.tsx(35,13): error TS2694: Namespace 'global.JSX' has no exported member 'Element'.
ELIFECYCLE Command failed with exit code 2.
Error: command finished with error: command
Contributor
There was a problem hiding this comment.
I think use ReactNode which represent any element can be rendered by react will be more suitable ~
Member
There was a problem hiding this comment.
@warjiang Need your help, the E2E test failed, I don't have a clue about that.
TimeoutError: page.waitForSelector: Timeout 30000ms exceeded.
Call log:
- waiting for locator('text=Overview') to be visible
at test-utils.ts:99
97 | await page.evaluate((t) => localStorage.setItem('token', t), token);
98 | await page.reload({ waitUntil: 'networkidle' });
> 99 | await page.waitForSelector('text=Overview', { timeout: 30000 });
| ^
100 | }
101 |
102 | /**
at setupDashboardAuthentication (/home/runner/work/dashboard/dashboard/karmada-dashboard/ui/apps/dashboard/e2e/test-utils.ts:99:16)
at /home/runner/work/dashboard/dashboard/karmada-dashboard/ui/apps/dashboard/e2e/workload/statefulset/statefulset-view.spec.ts:28:5
Contributor
|
/assign |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps react and @types/react. These dependencies needed to be updated together.
Updates
reactfrom 18.3.1 to 19.2.3Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.
... (truncated)
Commits
612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.15667a41Bump next prerelease version numbers (#34639)8bb7241Bump useEffectEvent to Canary (#34610)e3c9656Ensure Performance Track are Clamped and Don't overlap (#34509)68f00c9Release Activity in Canary (#34374)0e10ee9[Reconciler] Set ProfileMode for Host Root Fiber by default in dev (#34432)3bf8ab4Add missing Activity export to development mode (#34439)1549bda[Flight] Only assign_storein dev mode when creating lazy types (#34354)Updates
@types/reactfrom 18.3.11 to 19.2.7Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)