Skip to content

Conversation

@liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Jul 26, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • sign image of helm chart
  • renmae hack/package-helm-chart.sh to hack/helm-chart-package.sh for classify
  • mv signImage() to util.sh and rename util::signImage()

Which issue(s) this PR fixes:
Part2 of #3435

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Use cosign to sign  Images of karmada helm chart and karmada operator helm chart.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 26, 2023
@karmada-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liangyuanpeng liangyuanpeng changed the title Sign image helm chart Sign image for helm chart Jul 26, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2023
@liangyuanpeng liangyuanpeng force-pushed the sign_image_helmchart branch 2 times, most recently from e21201b to 390c97c Compare July 26, 2023 05:44
@liangyuanpeng liangyuanpeng changed the title Sign image for helm chart feat:sign image for helm chart Jul 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (961aa69) 52.84% compared to head (f3d8587) 52.84%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3841   +/-   ##
=======================================
  Coverage   52.84%   52.84%           
=======================================
  Files         239      239           
  Lines       23558    23558           
=======================================
  Hits        12450    12450           
+ Misses      10432    10431    -1     
- Partials      676      677    +1     
Flag Coverage Δ
unittests 52.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zishen zishen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@RainbowMango
Copy link
Member

@liangyuanpeng sorry for the delay. I'm not sure if I have enough time for this month, busying with KubeCon stuff recently.

@liangyuanpeng
Copy link
Contributor Author

@RainbowMango No worry, this is a low level issue. My talk of karmada for kubecon shanghai is missed and still wish you have fun 😄

@RainbowMango
Copy link
Member

Oh, what a pity~

@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Oct 30, 2023
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Oct 30, 2023
@RainbowMango
Copy link
Member

Ask @zhzhuang-zju to take a look and help.

@RainbowMango RainbowMango modified the milestones: v1.8, v1.9 Jan 9, 2024
@RainbowMango RainbowMango modified the milestones: v1.9, v1.10 Feb 29, 2024
@RainbowMango RainbowMango modified the milestones: v1.10, v1.11 May 29, 2024
@RainbowMango RainbowMango removed this from the v1.11 milestone Aug 28, 2024
@RainbowMango RainbowMango added this to the v1.12 milestone Aug 28, 2024
@RainbowMango RainbowMango modified the milestones: v1.12, v1.13 Nov 28, 2024
@RainbowMango RainbowMango modified the milestones: v1.13, v1.14 Apr 28, 2025
@RainbowMango RainbowMango modified the milestones: v1.14, v1.15 Jul 8, 2025
@RainbowMango RainbowMango modified the milestones: v1.15, v1.17 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants