Skip to content

CI: add ci for operator installation method #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhzhuang-zju wants to merge 1 commit into from
Closed

CI: add ci for operator installation method #4401

zhzhuang-zju wants to merge 1 commit into from

Conversation

@zhzhuang-zju
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju commented Dec 11, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • add ci for operator installation method, triggered when submitting files in the operator directory, to validate operator installation.
  • Scripts that provide quick installation of operator.
    image

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 11, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2023
liangyuanpeng
liangyuanpeng reviewed Dec 11, 2023
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.14%. Comparing base (5bc8c54) to head (934990e).
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4401      +/-   ##
==========================================
+ Coverage   53.12%   53.14%   +0.01%     
==========================================
  Files         251      251              
  Lines       20417    20417              
==========================================
+ Hits        10847    10851       +4     
+ Misses       8856     8853       -3     
+ Partials      714      713       -1
Flag Coverage Δ
unittests 53.14% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju zhzhuang-zju mentioned this pull request Apr 24, 2024
Merged
@XiShanYongYe-Chang
Copy link
Member

XiShanYongYe-Chang commented Apr 24, 2024

Ask @calvin0327 to help take a look.
/cc @calvin0327

@karmada-bot karmada-bot requested a review from calvin0327 April 24, 2024 03:42
@calvin0327
Copy link

calvin0327 commented Apr 24, 2024

/assign

calvin0327
calvin0327 reviewed Apr 24, 2024
View reviewed changes
@zhzhuang-zju zhzhuang-zju force-pushed the operator-installed branch 9 times, most recently from f392676 to 982eac4 Compare April 25, 2024 09:43
@zhzhuang-zju
Copy link
Contributor Author

zhzhuang-zju commented Apr 25, 2024

@calvin0327 Thank you for the review. Any other review comments?

@zhzhuang-zju
Copy link
Contributor Author

zhzhuang-zju commented May 6, 2024

kindly ping @calvin0327 @XiShanYongYe-Chang

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed May 6, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @liangyuanpeng

liangyuanpeng
liangyuanpeng reviewed May 6, 2024
View reviewed changes
liangyuanpeng
liangyuanpeng reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@zhzhuang-zju zhzhuang-zju force-pushed the operator-installed branch from 5b3b396 to 934990e Compare May 6, 2024 08:10
@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented May 6, 2024

/approve
for github workflow.

/hold
for avoid unexpected merge.

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@karmada-bot
Copy link
Contributor

karmada-bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liangyuanpeng
To complete the pull request process, please ask for approval from calvin0327 and additionally assign lfbear after the PR has been reviewed.
You can assign the PR to them by writing /assign @lfbear in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Jul 4, 2024

ping @calvin0327

@zhzhuang-zju zhzhuang-zju changed the title CI: add ci for operator installation method WIP: CI: add ci for operator installation method Sep 11, 2024
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
@zhzhuang-zju zhzhuang-zju changed the title WIP: CI: add ci for operator installation method CI: add ci for operator installation method Sep 11, 2024
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
@zhzhuang-zju zhzhuang-zju mentioned this pull request Sep 11, 2024
Merged
@zhzhuang-zju
Copy link
Contributor Author

zhzhuang-zju commented Sep 18, 2024

/close
tracked by #5519

@karmada-bot
Copy link
Contributor

karmada-bot commented Sep 18, 2024

@zhzhuang-zju: Closed this PR.

Details

In response to this:

/close
tracked by #5519

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaosi-zju chaosi-zju Awaiting requested review from chaosi-zju

@ikaven1024 ikaven1024 Awaiting requested review from ikaven1024

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

3 more reviewers

@liangyuanpeng liangyuanpeng liangyuanpeng left review comments

@calvin0327 calvin0327 calvin0327 left review comments

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@liangyuanpeng liangyuanpeng

@calvin0327 calvin0327

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhzhuang-zju @codecov-commenter @XiShanYongYe-Chang @calvin0327 @liangyuanpeng @karmada-bot