Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Priority and PreemptionPolicy fields in ResourceBinding #5963

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Add Priority and PreemptionPolicy fields in ResourceBinding #5963

merged 1 commit into from
Feb 18, 2025

Conversation

seanlaii
Copy link
Contributor

@seanlaii seanlaii commented Dec 19, 2024 •
edited
Loading

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:
Add SchedulePriority, Priority, and PreemptionPolicy fields in ResourceBinding to support priority-based scheduling. This enables:

  • Priority-based scheduling for ResourceBindings
  • Preemption control through PreemptionPolicy
  • Better control over scheduling order of workloads across clusters

Which issue(s) this PR fixes:
Part of #5961

Special notes for your reviewer:

  • Priority field is added as int32 to align with Kubernetes conventions
  • PreemptionPolicy supports two modes: Never (default) and PreemptLowerPriority

Does this PR introduce a user-facing change?:

Add SchedulePriority, Priority, and PreemptionPolicy fields to ResourceBinding API to support priority-based scheduling and preemption control.
- Priority: Defines scheduling priority (higher values = higher priority)
- PreemptionPolicy: Controls whether binding can preempt lower priority bindings

@karmada-bot karmada-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. labels Dec 19, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.11%. Comparing base (f555413) to head (bc6b042).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5963      +/-   ##
==========================================
- Coverage   48.12%   48.11%   -0.01%     
==========================================
  Files         668      668              
  Lines       55291    55291              
==========================================
- Hits        26607    26604       -3     
- Misses      26949    26952       +3     
  Partials     1735     1735
Flag Coverage Δ
unittests 48.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango RainbowMango mentioned this pull request Dec 19, 2024
Open
11 tasks
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2025
RainbowMango
RainbowMango reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

RainbowMango
RainbowMango reviewed Feb 18, 2025
View reviewed changes
pkg/apis/work/v1alpha2/binding_types.go Outdated
Comment on lines 353 to 360
// PreemptionPolicy controls the preemption policy of this binding.
// Valid values are:
// - Never: (default) prevents the binding from preempting other bindings
// - PreemptLowerPriority: allows the binding to preempt lower-priority bindings
// +kubebuilder:default=Never
// +kubebuilder:validation:Enum=Never;PreemptLowerPriority
// +optional
PreemptionPolicy PreemptionPolicy `json:"preemptionPolicy,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing the PreemptionPolicy this time? As we are not going to implement this in this release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, I removed the preemption part.

RainbowMango
RainbowMango approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@karmada-bot karmada-bot merged commit a8ea49c into karmada-io:master Feb 18, 2025
21 checks passed
@seanlaii seanlaii deleted the priority-binding branch February 18, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@a7i a7i Awaiting requested review from a7i

@Poor12 Poor12 Awaiting requested review from Poor12

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanlaii @codecov-commenter @karmada-bot @RainbowMango