-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom karmada component flags #6056
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ca99d20
to
a096b78
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6056 +/- ##
==========================================
+ Coverage 48.10% 48.12% +0.02%
==========================================
Files 668 668
Lines 55211 55289 +78
==========================================
+ Hits 26560 26609 +49
- Misses 26925 26948 +23
- Partials 1726 1732 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @calvin0327 |
28a5ee2
to
d02b7da
Compare
Signed-off-by: zhzhuang-zju <[email protected]>
d02b7da
to
00dd02b
Compare
What type of PR is this?
/kind api-change
/kind deprecation
What this PR does / why we need it
Karmada components offer a multitude of customizable features through flags, such as feature gates, allowing users to tailor their Karmada cluster according to their specific needs. Currently, the karmada-operator supports implementing these functionalities via fields like
extraArgs
, but:API
spec.featuregates
,spec.components.<component>.featureGates
andspec.components.<component>.extraArgs
all can be used to customize the component's featureGates. However, an excess of configurable options can confuse users and present challenges for future code maintenance.Component
local etcd
does not support the aforementioned capabilities.The previous implementation has some legacy items.
Based on these considerations, I referred to the
kubeadm
implementation and made modifications to it.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: