add support to enable scheduler estimator in helm chart

[mojojoji]

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds scheduler.enableSchedulerEstimator to helm values for karmada chart. This allows enables the scheduler to connect to scheduler estimator.

Which issue(s) this PR fixes:
Fixes #4368

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`Helm Chart`: Added `scheduler.enableSchedulerEstimator` to helm values for karmada chart to allow the scheduler to connect with the scheduler estimator.

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

[karmada-bot]

Welcome @mojojoji! It looks like this is your first PR to karmada-io/karmada 🎉

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.14%. Comparing base (5ce1645) to head (305b3b6).
Report is 18 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6286      +/-   ##
==========================================
+ Coverage   48.05%   48.14%   +0.08%     
==========================================
  Files         678      678              
  Lines       56116    56074      -42     
==========================================
+ Hits        26966    26995      +29     
+ Misses      27374    27310      -64     
+ Partials     1776     1769       -7     

Flag	Coverage Δ
unittests	48.14% <ø> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zhzhuang-zju]

/assign

[zhzhuang-zju]

@mojojoji Thanks, others LGTM

In addition to this, the component karmada-descheduler will also use the flag --enable-scheduler-estimator. Could you please submit another pull request (PR) to complete the modification of karmada-descheduler?

[mojojoji]

@mojojoji Thanks, others LGTM

In addition to this, the component karmada-descheduler will also use the flag --enable-scheduler-estimator. Could you please submit another pull request (PR) to complete the modification of karmada-descheduler?

The karamda-descheduler does not have a -enable-scheduler-estimator argument. I think descheduler assumes that the estimator is running and cannot run without it.

karmada/cmd/descheduler/app/options/options.go

Lines 106 to 137 in 8e18f30

	fs.BoolVar(&o.LeaderElection.LeaderElect, "leader-elect", true, "Enable leader election, which must be true when running multi instances.")
	fs.StringVar(&o.LeaderElection.ResourceNamespace, "leader-elect-resource-namespace", names.NamespaceKarmadaSystem, "The namespace of resource object that is used for locking during leader election.")
	fs.DurationVar(&o.LeaderElection.LeaseDuration.Duration, "leader-elect-lease-duration", defaultElectionLeaseDuration.Duration, ""+
	"The duration that non-leader candidates will wait after observing a leadership "+
	"renewal until attempting to acquire leadership of a led but unrenewed leader "+
	"slot. This is effectively the maximum duration that a leader can be stopped "+
	"before it is replaced by another candidate. This is only applicable if leader "+
	"election is enabled.")
	fs.DurationVar(&o.LeaderElection.RenewDeadline.Duration, "leader-elect-renew-deadline", defaultElectionRenewDeadline.Duration, ""+
	"The interval between attempts by the acting master to renew a leadership slot "+
	"before it stops leading. This must be less than or equal to the lease duration. "+
	"This is only applicable if leader election is enabled.")
	fs.DurationVar(&o.LeaderElection.RetryPeriod.Duration, "leader-elect-retry-period", defaultElectionRetryPeriod.Duration, ""+
	"The duration the clients should wait between attempting acquisition and renewal "+
	"of a leadership. This is only applicable if leader election is enabled.")
	fs.StringVar(&o.KubeConfig, "kubeconfig", o.KubeConfig, "Path to karmada control plane kubeconfig file.")
	fs.StringVar(&o.Master, "master", o.Master, "The address of the Kubernetes API server. Overrides any value in KubeConfig. Only required if out-of-cluster.")
	fs.Float32Var(&o.KubeAPIQPS, "kube-api-qps", 40.0, "QPS to use while talking with karmada-apiserver.")
	fs.IntVar(&o.KubeAPIBurst, "kube-api-burst", 60, "Burst to use while talking with karmada-apiserver.")
	fs.DurationVar(&o.SchedulerEstimatorTimeout.Duration, "scheduler-estimator-timeout", 3*time.Second, "Specifies the timeout period of calling the scheduler estimator service.")
	fs.IntVar(&o.SchedulerEstimatorPort, "scheduler-estimator-port", defaultEstimatorPort, "The secure port on which to connect the accurate scheduler estimator.")
	fs.StringVar(&o.SchedulerEstimatorCertFile, "scheduler-estimator-cert-file", "", "SSL certification file used to secure scheduler estimator communication.")
	fs.StringVar(&o.SchedulerEstimatorKeyFile, "scheduler-estimator-key-file", "", "SSL key file used to secure scheduler estimator communication.")
	fs.StringVar(&o.SchedulerEstimatorCaFile, "scheduler-estimator-ca-file", "", "SSL Certificate Authority file used to secure scheduler estimator communication.")
	fs.BoolVar(&o.InsecureSkipEstimatorVerify, "insecure-skip-estimator-verify", false, "Controls whether verifies the scheduler estimator's certificate chain and host name.")
	fs.StringVar(&o.SchedulerEstimatorServiceNamespace, "scheduler-estimator-service-namespace", names.NamespaceKarmadaSystem, "The namespace to be used for discovering scheduler estimator services.")
	fs.StringVar(&o.SchedulerEstimatorServicePrefix, "scheduler-estimator-service-prefix", names.KarmadaSchedulerEstimatorComponentName, "The prefix of scheduler estimator service name")
	fs.DurationVar(&o.DeschedulingInterval.Duration, "descheduling-interval", defaultDeschedulingInterval, "Time interval between two consecutive descheduler executions. Setting this value instructs the descheduler to run in a continuous loop at the interval specified.")
	fs.DurationVar(&o.UnschedulableThreshold.Duration, "unschedulable-threshold", defaultUnschedulableThreshold, "The period of pod unschedulable condition. This value is considered as a classification standard of unschedulable replicas.")
	fs.StringVar(&o.MetricsBindAddress, "metrics-bind-address", ":8080", "The TCP address that the server should bind to for serving prometheus metrics(e.g. 127.0.0.1:8080, :8080). It can be set to \"0\" to disable the metrics serving. Defaults to 0.0.0.0:8080.")
	fs.StringVar(&o.HealthProbeBindAddress, "health-probe-bind-address", ":10358", "The TCP address that the server should bind to for serving health probes(e.g. 127.0.0.1:10358, :10358). It can be set to \"0\" to disable serving the health probe. Defaults to 0.0.0.0:10358.")
	o.ProfileOpts.AddFlags(fs)

[zhzhuang-zju]

The karamda-descheduler does not have a -enable-scheduler-estimator argument. I think descheduler assumes that the estimator is running and cannot run without it.

@mojojoji I'm sorry for giving the incorrect advice. Indeed, the descheduler component doesn't have the "enable-scheduler-estimator" option.

The CI failed due to the DCO check. You can merge these two commits and use git commit -s -m to submit your commit.

[RainbowMango]

/lgtm
/approve

I see all comments have been fixed.
Thanks @mojojoji

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment