Skip to content

No longer add terminting NoExecute taint for the Deleting Cluster #6403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented May 24, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

No longer add the NoExecute taint for the Deleting Cluster.

Which issue(s) this PR fixes:
Part of #6317

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller`: The `cluster-controller` no longer relies on taints to clean up resources on clusters scheduled for deletion, but instead depends on the scheduler to reschedule workloads to other available clusters.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 24, 2025
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 24, 2025
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the no-longer-add-terminting-NoExecute-taint branch 2 times, most recently from ae66ac6 to 82e4c69 Compare May 24, 2025 07:10
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2025
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the no-longer-add-terminting-NoExecute-taint branch from 82e4c69 to 7b24950 Compare May 24, 2025 08:06
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 2.12766% with 46 lines in your changes missing coverage. Please review.

Project coverage is 49.05%. Comparing base (34e17a6) to head (8f954fb).

Files with missing lines Patch % Lines
pkg/scheduler/scheduler.go 0.00% 25 Missing ⚠️
cmd/controller-manager/app/controllermanager.go 0.00% 7 Missing ⚠️
pkg/controllers/cluster/cluster_controller.go 0.00% 7 Missing ⚠️
pkg/scheduler/core/generic_scheduler.go 0.00% 5 Missing ⚠️
pkg/scheduler/event_handler.go 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6403      +/-   ##
==========================================
- Coverage   49.18%   49.05%   -0.14%     
==========================================
  Files         685      685              
  Lines       55945    55969      +24     
==========================================
- Hits        27519    27458      -61     
- Misses      26629    26731     +102     
+ Partials     1797     1780      -17     
Flag Coverage Δ
unittests 49.05% <2.12%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the no-longer-add-terminting-NoExecute-taint branch 6 times, most recently from 70907de to 68724ab Compare May 29, 2025 07:57
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango

@karmada-bot karmada-bot requested a review from RainbowMango May 29, 2025 08:06
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the no-longer-add-terminting-NoExecute-taint branch from 68724ab to 9b949c4 Compare May 29, 2025 09:41
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good except some nits.

  1. Please remember to add a new E2E test to cover ClusterResourceBinding be take care during cluster termination
  2. Please consider another situation what if the cluster be removed forcelly, I mean without terminating?

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the no-longer-add-terminting-NoExecute-taint branch from 9b949c4 to 702fed9 Compare May 29, 2025 11:38
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the no-longer-add-terminting-NoExecute-taint branch from 702fed9 to 8f954fb Compare May 29, 2025 14:21
@RainbowMango
Copy link
Member

/title No longer relying on eviction to cleanup resources for clusters in terminating

@RainbowMango RainbowMango added this to the v1.14 milestone May 30, 2025
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2025
@karmada-bot karmada-bot merged commit 5bf846b into karmada-io:master May 30, 2025
24 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the no-longer-add-terminting-NoExecute-taint branch June 3, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants