-
Notifications
You must be signed in to change notification settings - Fork 940
No longer add terminting NoExecute taint for the Deleting Cluster #6403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer add terminting NoExecute taint for the Deleting Cluster #6403
Conversation
ae66ac6
to
82e4c69
Compare
82e4c69
to
7b24950
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6403 +/- ##
==========================================
- Coverage 49.18% 49.05% -0.14%
==========================================
Files 685 685
Lines 55945 55969 +24
==========================================
- Hits 27519 27458 -61
- Misses 26629 26731 +102
+ Partials 1797 1780 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
70907de
to
68724ab
Compare
/cc @RainbowMango |
68724ab
to
9b949c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good except some nits.
- Please remember to add a new E2E test to cover ClusterResourceBinding be take care during cluster termination
- Please consider another situation
what if the cluster be removed forcelly, I mean without terminating?
9b949c4
to
702fed9
Compare
Signed-off-by: changzhen <[email protected]>
702fed9
to
8f954fb
Compare
/title No longer relying on eviction to cleanup resources for clusters in terminating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
No longer add the NoExecute taint for the Deleting Cluster.
Which issue(s) this PR fixes:
Part of #6317
Special notes for your reviewer:
Does this PR introduce a user-facing change?: