Skip to content

Remove unnecessary update and delete events in cert-rotation-controller #6989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yaten2302 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unnecessary update and delete events in cert-rotation-controller #6989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c4ce0a
remove unnecessary update and delete events in cert-rotation-controller
yaten2302 Dec 2, 2025
97dc3da
fix linter errors in predicate.go
yaten2302 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/util/helper/predicate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,11 @@ func NewClusterPredicateOnAgent(clusterName string) predicate.Funcs {
CreateFunc: func(createEvent event.CreateEvent) bool {
return createEvent.Object.GetName() == clusterName
},
UpdateFunc: func(updateEvent event.UpdateEvent) bool {
return updateEvent.ObjectOld.GetName() == clusterName
UpdateFunc: func(_ event.UpdateEvent) bool {
return false
},
DeleteFunc: func(deleteEvent event.DeleteEvent) bool {
return deleteEvent.Object.GetName() == clusterName
DeleteFunc: func(_ event.DeleteEvent) bool {
return false
},
GenericFunc: func(event.GenericEvent) bool {
return false
Expand Down
4 changes: 2 additions & 2 deletions pkg/util/helper/predicate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ func TestNewClusterPredicateOnAgent(t *testing.T) {
obj: &clusterv1alpha1.Cluster{ObjectMeta: metav1.ObjectMeta{Name: "test"}},
want: want{
create: true,
update: true,
delete: true,
update: false,
delete: false,
generic: false,
},
},
Expand Down