-
Notifications
You must be signed in to change notification settings - Fork 1k
Bump sigs.k8s.io/metrics-server to v0.8.1-0.20251210102930-049165f394c7 #7022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sigs.k8s.io/metrics-server to v0.8.1-0.20251210102930-049165f394c7 #7022
Conversation
Signed-off-by: RainbowMango <[email protected]>
Summary of ChangesHello @RainbowMango, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive update of Go module dependencies across the project. Key changes include bumping Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates sigs.k8s.io/metrics-server to a pseudo-version, which also brings in updates to several other direct and indirect dependencies as reflected in go.mod and go.sum. The rationale for using a pseudo-version is clearly stated in the description. The changes are consistent with the goal of updating dependencies and appear to be correct. I have no further comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates sigs.k8s.io/metrics-server to pseudo version v0.8.1-0.20251210102930-049165f394c7 as explained in the description - there will not be a semantic version until Kubernetes v1.34 or Golang 1.26. This is a reasonable dependency management approach for tracking upstream changes.
Summary
- Bumps metrics-server to a pseudo version commit
- Updates transitive dependencies including gRPC (1.72.1→1.73.0), OpenTelemetry (1.35.0→1.36.0), and backoff (v4→v5)
- Replaces
interface{}withanyin metrics-server code (cosmetic change)
Reviewed changes
Copilot reviewed 1 out of 125 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/modules.txt | Updates all dependency versions including the primary metrics-server bump |
| vendor/sigs.k8s.io/metrics-server/pkg/api/table.go | Replaces interface{} with any type alias (no functional change) |
| vendor/google.golang.org/grpc/* | gRPC 1.73.0 update with new features (authority validation, name resolution tracking) |
| vendor/go.opentelemetry.io/otel/* | OpenTelemetry 1.36.0 update with various improvements |
| vendor/github.com/cenkalti/backoff/v5/* | Major version update from v4 to v5 with API changes |
| vendor/go.opentelemetry.io/contrib/* | Minor updates to HTTP instrumentation |
| vendor/github.com/onsi/gomega/* | Test framework update (1.37.0→1.38.0) |
All changes appear to be standard dependency updates from vendored packages. The metrics-server change itself is minimal (cosmetic type alias update), and the transitive dependency updates follow normal semantic versioning practices.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7022 +/- ##
==========================================
+ Coverage 46.60% 46.61% +0.01%
==========================================
Files 699 699
Lines 48182 48182
==========================================
+ Hits 22453 22461 +8
+ Misses 24032 24026 -6
+ Partials 1697 1695 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: whitewindmills The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR bumps sigs.k8s.io/metrics-server to a pseudo version
v0.8.1-0.20251210102930-049165f394c7as there will not be a semantic version until Kubernetes v1.36 or Golang 1.26, as mentioned at kubernetes-sigs/metrics-server#1739 (comment).Which issue(s) this PR fixes:
Fixes #
Part of #6862
Special notes for your reviewer:
Does this PR introduce a user-facing change?: