Skip to content

Conversation

@RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Dec 17, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR bumps sigs.k8s.io/metrics-server to a pseudo version v0.8.1-0.20251210102930-049165f394c7 as there will not be a semantic version until Kubernetes v1.36 or Golang 1.26, as mentioned at kubernetes-sigs/metrics-server#1739 (comment).

Which issue(s) this PR fixes:
Fixes #
Part of #6862

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copilot AI review requested due to automatic review settings December 17, 2025 03:20
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 17, 2025
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 17, 2025
@RainbowMango RainbowMango added this to the v1.17 milestone Dec 17, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @RainbowMango, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a comprehensive update of Go module dependencies across the project. Key changes include bumping sigs.k8s.io/metrics-server to a specific pseudo-version and a major version upgrade of the github.com/cenkalti/backoff library from v4 to v5, which necessitated adapting to its new API. Additionally, various components of OpenTelemetry and gRPC have been updated, bringing in new features, fixes, and improved compatibility with their latest versions.

Highlights

  • Dependency Updates: The primary change involves updating numerous Go module dependencies, including sigs.k8s.io/metrics-server to a pseudo-version, github.com/onsi/gomega to v1.38.0, golang.org/x/time to v0.12.0, google.golang.org/grpc to v1.73.0, and go.opentelemetry.io modules to v1.36.0/0.58.0/0.12.0.
  • Backoff Library Upgrade: The github.com/cenkalti/backoff library has been upgraded from v4 to v5, introducing significant API changes such as the removal of RetryNotify and RetryWithData functions, modifications to the ExponentialBackOff constructor, and the introduction of RetryAfterError.
  • OpenTelemetry HTTP Instrumentation Enhancements: Updates to go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp include improved span naming for http.ServeMux, refined metric recording, and enhanced attribute handling, particularly concerning the OTEL_SEMCONV_STABILITY_OPT_IN environment variable.
  • OpenTelemetry Core Improvements: The core OpenTelemetry library (go.opentelemetry.io/otel) received updates to its IDGenerator to utilize math/rand/v2, changes to attribute.Value handling, and modifications to propagation.Baggage to support the ValuesGetter interface for multi-value header extraction.
  • gRPC Client and Server Enhancements: gRPC (google.golang.org/grpc) updates include changes to ClientConn's address resolution waiting mechanism, the addition of an AuthorityValidator interface for credentials, and adjustments to clientStream behavior for CloseSend and RPC stats reporting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates sigs.k8s.io/metrics-server to a pseudo-version, which also brings in updates to several other direct and indirect dependencies as reflected in go.mod and go.sum. The rationale for using a pseudo-version is clearly stated in the description. The changes are consistent with the goal of updating dependencies and appear to be correct. I have no further comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates sigs.k8s.io/metrics-server to pseudo version v0.8.1-0.20251210102930-049165f394c7 as explained in the description - there will not be a semantic version until Kubernetes v1.34 or Golang 1.26. This is a reasonable dependency management approach for tracking upstream changes.

Summary

  • Bumps metrics-server to a pseudo version commit
  • Updates transitive dependencies including gRPC (1.72.1→1.73.0), OpenTelemetry (1.35.0→1.36.0), and backoff (v4→v5)
  • Replaces interface{} with any in metrics-server code (cosmetic change)

Reviewed changes

Copilot reviewed 1 out of 125 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vendor/modules.txt Updates all dependency versions including the primary metrics-server bump
vendor/sigs.k8s.io/metrics-server/pkg/api/table.go Replaces interface{} with any type alias (no functional change)
vendor/google.golang.org/grpc/* gRPC 1.73.0 update with new features (authority validation, name resolution tracking)
vendor/go.opentelemetry.io/otel/* OpenTelemetry 1.36.0 update with various improvements
vendor/github.com/cenkalti/backoff/v5/* Major version update from v4 to v5 with API changes
vendor/go.opentelemetry.io/contrib/* Minor updates to HTTP instrumentation
vendor/github.com/onsi/gomega/* Test framework update (1.37.0→1.38.0)

All changes appear to be standard dependency updates from vendored packages. The metrics-server change itself is minimal (cosmetic type alias update), and the transitive dependency updates follow normal semantic versioning practices.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.61%. Comparing base (9ba7dc0) to head (983631b).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7022      +/-   ##
==========================================
+ Coverage   46.60%   46.61%   +0.01%     
==========================================
  Files         699      699              
  Lines       48182    48182              
==========================================
+ Hits        22453    22461       +8     
+ Misses      24032    24026       -6     
+ Partials     1697     1695       -2     
Flag Coverage Δ
unittests 46.61% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RainbowMango
Copy link
Member Author

cc @whitewindmills

@whitewindmills
Copy link
Member

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: whitewindmills

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2025
@karmada-bot karmada-bot merged commit 5506336 into karmada-io:master Dec 18, 2025
29 of 30 checks passed
@RainbowMango RainbowMango deleted the pr_bump_metrics-server branch December 18, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants