Skip to content

Conversation

@zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Currently, Gemini maintains its own style guide. To simplify maintenance and ensure consistency across tools, I propose adding a single STYLE_GUIDE.md file directly in the Karmada repository. All agents (Gemini, Copilot, etc.) can then reference this shared guide—keeping their context aligned while still allowing tool-specific customization.

Test Reports:
JesseStutler#2 (comment) (copilot)
zhzhuang-zju#14 (comment) (Gemini)

Which issue(s) this PR fixes:

Parts of #7055

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 4, 2026
@karmada-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign whitewindmills for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @zhzhuang-zju, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request centralizes the code style and quality guidelines for the Karmada project by introducing a new CODE_STYLE_GUIDE.md file. This initiative aims to ensure consistency across the codebase, particularly for AI-assisted tools like Copilot and Gemini, which will now reference this unified guide. The comprehensive guidelines cover various aspects of Go development, secure coding, and release note formatting, intending to simplify maintenance, reduce review iterations, and improve overall code quality.

Highlights

  • Centralized Style Guide: Introduced a new CODE_STYLE_GUIDE.md file to establish a single, consistent set of coding standards for the Karmada project.
  • AI Tool Integration: Updated .github/copilot-instructions.md to direct AI-assisted tools like Copilot to reference the new centralized style guide, promoting uniformity in code reviews and generated content.
  • Comprehensive Guidelines: The new style guide provides detailed rules for Go code comments, compile-time interface compliance checks, function parameter best practices, secure coding specifications, and standardized CHANGELOG entry formatting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .gemini/** (1)
    • .gemini/styleguide.md
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 4, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a centralized style guide for AI-assisted code reviews, which is a great initiative for ensuring consistency across the project. The new documentation is well-structured. I have provided a few minor suggestions to improve clarity and maintainability, such as updating a hardcoded link to prevent it from becoming stale and fixing some small typos. I also noted a minor inconsistency in the naming of the style guide file compared to the PR description and suggested a change for better alignment. Overall, these changes are beneficial and will help streamline the review process.

@@ -0,0 +1,170 @@
Karmada is primarily developed in Go and follows the standard Go community coding conventions. Automated style checks are
enforced via [golangci-lint](https://github.com/karmada-io/karmada/blob/e2c4b596a5da442fc0dbeab9f9063d8db8669208/.github/workflows/ci.yml#L18-L35).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The link to the golangci-lint configuration uses a specific commit hash. This can become outdated as the CI workflow evolves. It's better to use a branch name like master to ensure the link always points to the latest version of the file.

Suggested change
enforced via [golangci-lint](https://github.com/karmada-io/karmada/blob/e2c4b596a5da442fc0dbeab9f9063d8db8669208/.github/workflows/ci.yml#L18-L35).
enforced via [golangci-lint](https://github.com/karmada-io/karmada/blob/master/.github/workflows/ci.yml#L18-L35).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
It seems sensible.


- Any struct that explicitly implements an interface must include a compile-time interface compliance check.

using the following pattern:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to follow standard sentence capitalization, 'using' should be capitalized.

Suggested change
using the following pattern:
Using the following pattern:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

- The random numbers used in cryptographic algorithms must be secure random numbers in the cryptographic sense.
- It is prohibited to print authentication credentials (passwords/private keys/pre-shared keys) in plain text in system-stored logs, debugging information, and error prompts.

## CHANGELOG(Release Notes)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a small typo in the heading. It should be CHANGELOG (Release Notes) with a space for better readability.

Suggested change
## CHANGELOG(Release Notes)
## CHANGELOG (Release Notes)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.56%. Comparing base (ffa0dfb) to head (fda9f9c).
⚠️ Report is 17 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7073   +/-   ##
=======================================
  Coverage   46.55%   46.56%           
=======================================
  Files         700      700           
  Lines       48084    48084           
=======================================
+ Hits        22387    22390    +3     
+ Misses      24013    24011    -2     
+ Partials     1684     1683    -1     
Flag Coverage Δ
unittests 46.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, I don't want to put too many configuration files under the repo root directory.
Is it possible to put the code style file under .github directory and let Gemini read the file from there?

@zhzhuang-zju
Copy link
Contributor Author

One more thing, I don't want to put too many configuration files under the repo root directory. Is it possible to put the code style file under .github directory and let Gemini read the file from there?

Theoretically, it's possible. I will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants