-
Notifications
You must be signed in to change notification settings - Fork 1k
add a centralized STYLE_GUIDE in Karmada for consistent AI-assisted code reviews #7073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ode reviews Signed-off-by: zhzhuang-zju <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @zhzhuang-zju, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request centralizes the code style and quality guidelines for the Karmada project by introducing a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a centralized style guide for AI-assisted code reviews, which is a great initiative for ensuring consistency across the project. The new documentation is well-structured. I have provided a few minor suggestions to improve clarity and maintainability, such as updating a hardcoded link to prevent it from becoming stale and fixing some small typos. I also noted a minor inconsistency in the naming of the style guide file compared to the PR description and suggested a change for better alignment. Overall, these changes are beneficial and will help streamline the review process.
| @@ -0,0 +1,170 @@ | |||
| Karmada is primarily developed in Go and follows the standard Go community coding conventions. Automated style checks are | |||
| enforced via [golangci-lint](https://github.com/karmada-io/karmada/blob/e2c4b596a5da442fc0dbeab9f9063d8db8669208/.github/workflows/ci.yml#L18-L35). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the golangci-lint configuration uses a specific commit hash. This can become outdated as the CI workflow evolves. It's better to use a branch name like master to ensure the link always points to the latest version of the file.
| enforced via [golangci-lint](https://github.com/karmada-io/karmada/blob/e2c4b596a5da442fc0dbeab9f9063d8db8669208/.github/workflows/ci.yml#L18-L35). | |
| enforced via [golangci-lint](https://github.com/karmada-io/karmada/blob/master/.github/workflows/ci.yml#L18-L35). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
It seems sensible.
|
|
||
| - Any struct that explicitly implements an interface must include a compile-time interface compliance check. | ||
|
|
||
| using the following pattern: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
| - The random numbers used in cryptographic algorithms must be secure random numbers in the cryptographic sense. | ||
| - It is prohibited to print authentication credentials (passwords/private keys/pre-shared keys) in plain text in system-stored logs, debugging information, and error prompts. | ||
|
|
||
| ## CHANGELOG(Release Notes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7073 +/- ##
=======================================
Coverage 46.55% 46.56%
=======================================
Files 700 700
Lines 48084 48084
=======================================
+ Hits 22387 22390 +3
+ Misses 24013 24011 -2
+ Partials 1684 1683 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RainbowMango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
RainbowMango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing, I don't want to put too many configuration files under the repo root directory.
Is it possible to put the code style file under .github directory and let Gemini read the file from there?
Theoretically, it's possible. I will give it a try. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Currently, Gemini maintains its own style guide. To simplify maintenance and ensure consistency across tools, I propose adding a single STYLE_GUIDE.md file directly in the Karmada repository. All agents (Gemini, Copilot, etc.) can then reference this shared guide—keeping their context aligned while still allowing tool-specific customization.
Test Reports:
JesseStutler#2 (comment) (copilot)
zhzhuang-zju#14 (comment) (Gemini)
Which issue(s) this PR fixes:
Parts of #7055
Special notes for your reviewer:
Does this PR introduce a user-facing change?: