add cmdinit e2e test for initing karmada control plane with config file

[rayo1uo]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently, it supports testing the installation capability of karmadactl init in e2e. The tests for CI Test on Kubernetes and CI init with config file can now be migrated to the e2e module.

Which issue(s) this PR fixes:

Part of #6887

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[gemini-code-assist]

Summary of Changes

Hello @rayo1uo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the testing infrastructure for Karmada by introducing a robust, Go-based end-to-end test for the karmadactl init command when it's used with a configuration file. This change migrates existing testing logic from a shell script into the e2e module, ensuring more reliable and integrated validation of the Karmada control plane initialization process. The update is part of a broader effort to improve the project's testing coverage and maintainability.

Highlights

• New E2E Test for karmadactl init with Config File: A new end-to-end test has been added to validate the karmadactl init command when initializing the Karmada control plane using a configuration file. This test ensures the installation capability works as expected with a declarative configuration.
• Removal of Old Shell Script: The previous shell script hack/cli-testing-init-with-config.sh, which performed similar setup and testing for karmadactl init with a config file, has been removed. Its functionality is now covered by the new Go-based e2e test.
• Simplified Error Handling: Minor cleanup was performed in test/e2e/suites/init/suite_test.go to simplify error handling in the setupTestNamespace and cleanupTestNamespace functions, making the code more concise.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/installation-cli.yaml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request migrates the karmadactl init with config file test from a shell script to a Go e2e test, which is a great improvement for maintainability. The shell script hack/cli-testing-init-with-config.sh is removed and a new Go test file test/e2e/suites/init/init_with_config_test.go is added. The changes in test/e2e/suites/init/suite_test.go are good stylistic simplifications. I've found a critical issue in the new test file related to incorrect YAML formatting in the config template, which would cause the test to fail. Please see my detailed comment.

[Copilot]

Pull request overview

This PR migrates the karmadactl init with config file test from a bash script approach to the e2e test framework, consolidating testing infrastructure and removing duplicate CI workflows.

• Adds new e2e test (init_with_config_test.go) for testing karmadactl init with configuration files
• Removes the legacy bash script (hack/cli-testing-init-with-config.sh) and corresponding GitHub workflow job
• Simplifies helper functions in suite_test.go by removing unnecessary error handling boilerplate

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
test/e2e/suites/init/init_with_config_test.go	New e2e test for initializing Karmada control plane using config file
test/e2e/suites/init/suite_test.go	Simplified helper functions by directly returning error values
hack/cli-testing-init-with-config.sh	Removed legacy bash-based test script (migrated to e2e)
.github/workflows/installation-cli.yaml	Removed init-config job that used the deprecated bash script

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[zhzhuang-zju]

Thanks
/lgtm
/assign

[zhzhuang-zju]

/lgtm cancel

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.55%. Comparing base (b175217) to head (4d3550d).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7080   +/-   ##
=======================================
  Coverage   46.55%   46.55%           
=======================================
  Files         700      700           
  Lines       48091    48091           
=======================================
+ Hits        22389    22391    +2     
+ Misses      24020    24018    -2     
  Partials     1682     1682           

Flag	Coverage Δ
unittests	46.55% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• .github/workflows/OWNERS
• hack/OWNERS
• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rayo1uo]

Hi @zhzhuang-zju , ready for review again. Thanks~

Also, regarding the screenshot, I think 'init with config' needs to be removed from the repo settings as it's stuck in pending, which has been removed from workflow yaml.