Skip to content

feat: add complete interpreter test coverage for DaemonSet #7084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
7h3-3mp7y-m4n wants to merge 1 commit into
base: master
Choose a base branch
from
+101 −0
Draft

feat: add complete interpreter test coverage for DaemonSet #7084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 101 additions & 0 deletions ...sourcecustomizations/apps.kruise.io/v1alpha1/DaemonSet/testdata/interprethealth-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# test case for interpreting health of DaemonSet
# case1. DaemonSet interpreting health test
# case2: Generation mismatch
# case3: Not all updated pods are available
# case4: Not all pods updated


name: "DaemonSet interpreting health test"
description: "Test interpreting health of DaemonSet"
Expand Down Expand Up @@ -52,3 +56,100 @@ observedObj:
updatedNumberScheduled: 1
operation: InterpretHealth
output:
healthy: true

---
# Case2:
name: "DaemonSet unhealthy - generation mismatch"
description: "Test InterpretHealth returns false when observedGeneration doesn't match generation"
observedObj:
apiVersion: apps.kruise.io/v1alpha1
kind: DaemonSet
metadata:
name: sample
namespace: test-kruise-daemonset
generation: 5
spec:
selector:
matchLabels:
app: sample-daemonset
template:
metadata:
labels:
app: sample-daemonset
spec:
containers:
- name: nginx
image: nginx:alpine
status:
observedGeneration: 3
desiredNumberScheduled: 3
updatedNumberScheduled: 3
numberAvailable: 3
operation: InterpretHealth
output:
healthy: false

---
# Case3:
name: "DaemonSet unhealthy - not all updated pods available"
description: "Test InterpretHealth returns false when numberAvailable < updatedNumberScheduled"
observedObj:
apiVersion: apps.kruise.io/v1alpha1
kind: DaemonSet
metadata:
name: sample
namespace: test-kruise-daemonset
generation: 2
spec:
selector:
matchLabels:
app: sample-daemonset
template:
metadata:
labels:
app: sample-daemonset
spec:
containers:
- name: nginx
image: nginx:alpine
status:
observedGeneration: 2
desiredNumberScheduled: 5
updatedNumberScheduled: 5
numberAvailable: 3
operation: InterpretHealth
output:
healthy: false

---
# Case4:
name: "DaemonSet unhealthy - not all pods updated"
description: "Test InterpretHealth returns false when updatedNumberScheduled < desiredNumberScheduled"
observedObj:
apiVersion: apps.kruise.io/v1alpha1
kind: DaemonSet
metadata:
name: sample
namespace: test-kruise-daemonset
generation: 2
spec:
selector:
matchLabels:
app: sample-daemonset
template:
metadata:
labels:
app: sample-daemonset
spec:
containers:
- name: nginx
image: nginx:alpine
status:
observedGeneration: 2
desiredNumberScheduled: 5
updatedNumberScheduled: 3
Copy link

@gemini-code-assist gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is trailing whitespace on this line. While it may not affect YAML parsing in this context, it's considered a good practice to remove it to maintain code cleanliness and prevent potential issues with tools that are sensitive to whitespace.

    updatedNumberScheduled: 3

numberAvailable: 3
operation: InterpretHealth
output:
healthy: false
Copy link

@gemini-code-assist gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file is missing a newline character at the end. It's a standard convention (part of the POSIX standard for text files) to end files with a newline. This ensures file integrity and prevents issues with some command-line tools that process text files.

  healthy: false