feat: add scheduler empty-workload chart option

[tamarubin]

Summary

• add scheduler.enableEmptyWorkloadPropagation as a Helm value for the scheduler
• render --enable-empty-workload-propagation=true when the value is enabled
• document the new value in the chart README options table

Test plan

• run helm template karmada ./charts/karmada --set scheduler.enableEmptyWorkloadPropagation=true
• confirm scheduler command output includes --enable-empty-workload-propagation=true

Made with Cursor

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign a7i for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[karmada-bot]

Welcome @tamarubin! It looks like this is your first PR to karmada-io/karmada 🎉

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option for the Karmada scheduler, enabling users to control the propagation of workloads with zero replicas. By adding a new Helm value and updating the deployment template, the change provides a flexible way to manage this specific scheduling behavior without requiring manual command-line overrides.

Highlights

• New Helm Configuration: Added the scheduler.enableEmptyWorkloadPropagation parameter to the Helm chart values to allow toggling of zero-replica workload propagation.
• Scheduler Template Update: Updated the scheduler deployment template to conditionally inject the --enable-empty-workload-propagation=true flag based on the new Helm value.
• Documentation: Updated the chart README to include the new configuration option in the options table.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a Helm chart value and corresponding scheduler flag to optionally enable propagation of zero-replica workloads in karmada-scheduler, and documents the new setting.

Changes:

• Introduce scheduler.enableEmptyWorkloadPropagation in values.yaml (default false)
• Conditionally add --enable-empty-workload-propagation=true to the scheduler container args when enabled
• Document the new chart value in the chart README parameter table

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
charts/karmada/values.yaml	Adds a new scheduler value toggle with inline parameter documentation.
charts/karmada/templates/karmada-scheduler.yaml	Wires the new value to a conditional scheduler CLI flag.
charts/karmada/README.md	Documents the new scheduler.enableEmptyWorkloadPropagation option.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request introduces a new configuration option, scheduler.enableEmptyWorkloadPropagation, to the Karmada Helm chart. This parameter allows users to enable scheduler propagation for zero-replica workloads by passing the --enable-empty-workload-propagation=true flag to the karmada-scheduler deployment. The option defaults to false and has been documented in the chart's README and values files. I have no feedback to provide as the changes are straightforward and correct.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.17%. Comparing base (bbabd79) to head (38135f5).
⚠️ Report is 10 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7570      +/-   ##
==========================================
+ Coverage   42.16%   42.17%   +0.01%     
==========================================
  Files         879      879              
  Lines       54682    54729      +47     
==========================================
+ Hits        23055    23083      +28     
- Misses      29896    29911      +15     
- Partials     1731     1735       +4     

Flag	Coverage Δ
unittests	42.17% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.