Skip to content

update override-policy docs#1009

Merged
karmada-bot merged 1 commit into
karmada-io:mainfrom
zhzhuang-zju:plaintextOverrider
May 28, 2026
Merged

update override-policy docs#1009
karmada-bot merged 1 commit into
karmada-io:mainfrom
zhzhuang-zju:plaintextOverrider

Conversation

@zhzhuang-zju
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Ref to karmada-io/karmada#3923 (comment) and karmada-io/karmada#3362 (comment), this pr adds examples for overriding container env in the PlaintextOverrider section of the override policy documentation.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 19, 2026
@karmada-bot karmada-bot requested review from Poor12 and windsonsea May 19, 2026 08:58
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 19, 2026
Copy link
Copy Markdown
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the PlaintextOverrider to specify its alignment with RFC 6902 (JSON Patch) and provides more detailed explanations for the add, remove, and replace operations. It also introduces a new example demonstrating how to manage container environment variables. Feedback was provided to remove trailing spaces in the markdown files to maintain document quality.

Comment thread docs/userguide/scheduling/override-policy.md Outdated
Comment thread docs/userguide/scheduling/override-policy.md Outdated
Comment thread docs/userguide/scheduling/override-policy.md
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@zhzhuang-zju
Copy link
Copy Markdown
Contributor Author

/cc @RainbowMango

Copy link
Copy Markdown
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2026
@karmada-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@karmada-bot karmada-bot merged commit 4153c14 into karmada-io:main May 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants