clean up upgrade docs navigation and fix missing visibility of v1.16-v1.17#1013
Conversation
karmada-bot
added
the
kind/feature
|
Welcome @vanshiz! It looks like this is your first PR to karmada-io/website 🎉 |
karmada-bot
added
the
size/M
vanshiz
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request streamlines the upgrade documentation by replacing a long list of version-specific links in the README files with a general instruction to refer to the corresponding guides. It also adds the v1.16-v1.17 upgrade path to the sidebar configurations. Feedback focuses on improving terminology consistency by capitalizing "PATCH" and "MINOR" to match other sections, as well as refining sentence structure and formatting in the documentation.
vanshiz
force-pushed
the
cleanup-upgrade-docs
branch
from
8cc3de1 to
289c492
Compare
|
Thanks @vanshiz. Generally LGTM, please squash the commits into one, so we can move forward |
…v1.17 Signed-off-by: vanshiz <vanshikabhargava29@gmail.com>
vanshiz
force-pushed
the
cleanup-upgrade-docs
branch
from
289c492 to
24fd9d9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
4 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
docs/administrator/upgrading/README.mdandi18n/zh/docusaurus-plugin-content-docs/current/administrator/upgrading/README.mdto reduce manual maintenance overhead. The sidebar already handles navigation for these docs.v1.16-v1.17tosidebars.jsandversioned_sidebars/version-v1.17-sidebars.jsonto make the existingv1.16-v1.17.mdvisible on the website.Which issue(s) this PR fixes:
Fixes #1011
Special notes for your reviewer:
N/A