Normalize line endings to LF and add .gitattributes for branch release 1.17#1028
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
karmada-bot
added
the
size/XXL
…e-1.17 Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: MilindRastogi24 <milindrastogicloud@gmail.com>
MilindRastogi24
force-pushed
the
eliminate-crlf-line-endings-release-1.17
branch
from
5dbf29b to
e327407
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a .gitattributes file to normalize line endings across the repository and updates several documentation files (including translated and versioned versions) to ensure consistent formatting. The review feedback suggests explicitly configuring Windows batch files (*.bat and *.cmd) to use CRLF line endings in .gitattributes to prevent execution failures on Windows, and correcting a missing trailing newline and trailing whitespace in one of the upgrading documentation files.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| *.pdf binary | ||
|
|
||
| # Shell scripts must use LF | ||
| *.sh text eol=lf |
There was a problem hiding this comment.
When enforcing LF line endings repository-wide using * text=auto eol=lf, Windows batch files (*.bat and *.cmd) must still use CRLF line endings to execute correctly on Windows systems. It is highly recommended to explicitly configure them to use CRLF.
*.sh text eol=lf
# Windows batch files must use CRLF
*.bat text eol=crlf
*.cmd text eol=crlf
| ### karmada-controller-manager | ||
|
|
||
| - Introduced feature gate `StatefulFailoverInjection` to control whether Karmada collects and injects state information during a failover event for stateful application. | ||
| - The feature `Failover` now has been disabled by default, which should be explicitly enabled to avoid unexpected incidents. No newline at end of file |
There was a problem hiding this comment.
The file does not end with a newline character (non-POSIX compliant) and contains trailing whitespace at the end of line 45. It is recommended to remove the trailing whitespace and ensure the file ends with a single trailing newline to comply with standard POSIX text file formatting and avoid git warnings.
MilindRastogi24
changed the title
2 participants
…e-1.17
What type of PR is this?
kind feature
What this PR does / why we need it:
Normalize line endings to LF and add .gitattributes for the release-1.17 branch
Enforce LF line endings repository-wide and convert 24 files that were
committed with CRLF.
Which issue(s) this PR fixes:
Part of #1026
Special notes for your reviewer: