Normalize line endings to LF and add .gitattributes for branch release 1.18#1030
Conversation
…e-1.18 Signed-off-by: MilindRastogi24 <milindrastogicloud@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request adds a .gitattributes file to normalize line endings across the repository and applies minor formatting and translation updates to various documentation files. The review feedback correctly points out that Windows batch files (.bat and .cmd) require CRLF line endings to execute properly, and suggests adding explicit rules for them in .gitattributes to override the global LF setting.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # Shell scripts must use LF | ||
| *.sh text eol=lf |
There was a problem hiding this comment.
Windows batch files (.bat and .cmd) require CRLF line endings to execute correctly in Windows environments. Since the global rule * text=auto eol=lf forces LF line endings on all text files, any batch files added to the repository will be checked out with LF line endings, which can cause syntax and execution errors on Windows. It is recommended to explicitly configure CRLF for these file extensions.
# Shell scripts must use LF
*.sh text eol=lf
# Windows batch files must use CRLF
*.bat text eol=crlf
*.cmd text eol=crlf
…e-1.18
What type of PR is this?
kind feature
What this PR does / why we need it:
Normalize line endings to LF and add .gitattributes for the main branch
Enforce LF line endings repository-wide and convert 29 files that were
committed with CRLF.
Which issue(s) this PR fixes:
Part of #1026
Special notes for your reviewer: