-
Notifications
You must be signed in to change notification settings - Fork 273
Rk stratum2.0 fixed #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Rk stratum2.0 fixed #877
Changes from all commits
ee811d7
f556e06
f655a2f
be72887
305a640
22b9658
0cb38fd
0ba9cd1
47ea3e3
6dfdc49
97cd6bc
81f7d7c
5d70158
5f6e8b0
e6569dd
0b1d1db
abfc362
f7d9fc8
178cd5f
65f5bed
0bc1cba
9f4de7b
3c86df0
534c90b
4eaf195
74e935d
738da33
cc3a28e
99733e7
16f334c
2c2e41a
2a17c94
31c64ff
fc6b5b4
a957b97
05e5e7e
ae36ac5
70bd81b
e7f63f5
1e45de3
10280f3
64b0bd9
9dfe415
ffa223c
d61ff85
8964e40
be51c98
60bb4b7
67178a8
b3afff9
7751746
8a6584b
3b57e9a
29be82e
bab99d9
ee94eb8
d6ff817
df344b8
c70a903
9d5f7f9
ce06697
f6da5e5
a40d5b2
2d4755c
3db9176
463c4d6
21aaf3a
3ab9119
c5c8afb
3a5323c
1642e55
7668224
3fd7518
2d43a3e
5d48147
bbe14bb
5de8733
a63d55c
7b54b9e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,84 +1,57 @@ | ||
| # RustBridge Multi-Instance Test Configuration | ||
| # RKStratum Multi-Instance Test Configuration | ||
| # This configuration runs 4 instances for testing the multi-instance feature | ||
| # All instances share the same Kaspa node (kaspad_address) | ||
| # | ||
| # NOTE: Comments in this file will be lost if you update the configuration | ||
| # through the web dashboard. The web UI uses serde_yaml which does not | ||
| # preserve comments. For production, consider keeping a backup or using | ||
| # version control. | ||
|
|
||
| # ============================================ | ||
| # GLOBAL SETTINGS (shared by all instances) | ||
| # ============================================ | ||
|
|
||
| # Kaspa node gRPC address (SHARED - all instances use the same node) | ||
| # Format: "HOST:PORT" or "grpc://HOST:PORT" | ||
| # Default HTTP gRPC port is typically 16110 | ||
| # Use 127.0.0.1 instead of localhost to force IPv4 | ||
| kaspad_address: "127.0.0.1:16110" | ||
|
|
||
| # Block template wait time in milliseconds (shared) | ||
| # How long to wait between checking for new block templates | ||
| block_wait_time: 1000 | ||
|
|
||
| # Print statistics to console (shared) | ||
| print_stats: true | ||
|
|
||
| # Default log to file setting (can be overridden per-instance) | ||
| log_to_file: true | ||
|
|
||
| # Health check server port (optional, leave empty to disable) | ||
| # This is a GLOBAL health check endpoint | ||
| health_check_port: "" | ||
|
|
||
| # Variable difficulty settings (defaults, can be overridden per-instance) | ||
| var_diff: false | ||
| shares_per_min: 20 | ||
| var_diff_stats: false | ||
|
|
||
| # Power-of-2 difficulty clamping (default, can be overridden per-instance) | ||
| web_dashboard_port: ":3030" | ||
| var_diff: true | ||
| shares_per_min: 30 | ||
| var_diff_stats: true | ||
| pow2_clamp: true | ||
|
|
||
| # Extranonce size (auto-detected per client, this is just for backward compatibility) | ||
| extranonce_size: 2 | ||
|
|
||
| # Optional: append a custom identifier to the built-in coinbase tag (applies to BOTH node modes). | ||
| # You CANNOT change/override the built-in base tag; you can only append a suffix. | ||
| # Built-in base tag is fixed: | ||
| # - "RK-Stratum" | ||
| # Set this to a short identifier (no leading slash). It will be appended as `/SUFFIX`. | ||
| # Examples (if coinbase_tag_suffix: "supertypo"): | ||
| # - "RK-Stratum/supertypo" | ||
| coinbase_tag_suffix: "" | ||
|
|
||
| # ============================================ | ||
| # INSTANCE CONFIGURATIONS | ||
| # ============================================ | ||
| # Each instance runs independently with its own: | ||
| # - Stratum port (REQUIRED, must be unique) | ||
| # - Minimum share difficulty (REQUIRED) | ||
| # - Prometheus port (OPTIONAL, per-instance) | ||
| # - Log to file (OPTIONAL, per-instance, defaults to global setting) | ||
|
|
||
| instances: | ||
| # Instance 1: Low difficulty pool (for smaller miners or testing) | ||
| - stratum_port: ":5559" | ||
| min_share_diff: 4 | ||
| prom_port: ":2118" | ||
| log_to_file: true | ||
|
|
||
| - stratum_port: ":5560" | ||
| min_share_diff: 512 | ||
| prom_port: ":2119" | ||
| log_to_file: true | ||
|
|
||
| - stratum_port: ":5561" | ||
| min_share_diff: 1024 | ||
| prom_port: ":2120" | ||
| log_to_file: true | ||
|
|
||
|
Comment on lines
+24
to
+38
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These extra ports aren't documented.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Default config / ports (Port | Purpose table), including :5559, :5560, :5561 and prom ports.” |
||
| - stratum_port: ":5555" | ||
| min_share_diff: 2048 | ||
| prom_port: ":2114" | ||
| log_to_file: true | ||
|
|
||
| # Instance 2: Medium difficulty pool | ||
| - stratum_port: ":5556" | ||
| min_share_diff: 4096 | ||
| prom_port: ":2115" | ||
| log_to_file: true | ||
|
|
||
| # Instance 3: High difficulty pool (for powerful miners) | ||
| - stratum_port: ":5557" | ||
| min_share_diff: 8192 | ||
| prom_port: ":2116" | ||
| log_to_file: true | ||
|
|
||
| # Instance 4: Very high difficulty pool (for very powerful miners) | ||
| - stratum_port: ":5558" | ||
| min_share_diff: 16384 | ||
| prom_port: ":2117" | ||
| log_to_file: true | ||
| # Optional: instance-specific overrides | ||
| # var_diff: true | ||
| # shares_per_min: 30 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? Have you verified that this does not impact the
kaspadbinary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the flag exists:
kaspa-alloc uses mimalloc with "override" for non-macos targets (including musl)
The bridge also has a direct mimalloc dependency for musl builds (without override)
This creates a dual mimalloc dependency structure that requires the flag.
It does not impact kaspad binary.
The change was so that we did not have to make any changes directly to Util
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@biryukovmaxim do you have any recommendations here? I'm just concerned this applied at the top level like this affects all binaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry I have no expertise of what it could lead to. @saefstroem since you built musl step in ci, maybe you have any advices, considerations here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it mean you can remove direct dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably will do the same only for bridge crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this more, this is probably fine to have.
@saefstroem would like to get your confirmation here too.