Open
Conversation
dd97bbb to
4e64eb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these issues should affect consensus
overflowing_*variants, and theMultrait impl ignores the overflow bit in release mode (it uses adebug_assert) so nothing should really be affected)..size_hint()iterator impl for the iterator returned at.iter_be_bits()when combined with the overriden.nth()function.as_f64when used onUint3072on values above ~2^1024 (before it could return garbage values, now it will always return Inf in those cases)First commit just makes the
construct_macrowork in the fuzzing infra again.Second commit improves the tests and fuzzing to catch these errors:
Test Failures
Fuzzing Failures
The rest of the commits fix those issues