Add xg_lfCellLogFont (LOGFONTW-based) cell font management with CellLogFont LOOKS support - #92
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Extend internal management of font settings to LOGFONTW
Add xg_lfCellLogFont (LOGFONTW-based) cell font management with CellLogFont LOOKS support
Jul 1, 2026
katahiromz
requested changes
Jul 1, 2026
Owner
There was a problem hiding this comment.
@copilot 盤の描画も xg_lfCellLogFont を反映するようにして。
レジストリにも xg_lfCellLogFontを保存・読み込みするようにして。
ただし、互換性・操作性を変えないで。
Contributor
Author
対応しました(コミット: Reflect xg_lfCellLogFont in board drawing and registry save/load)。
|
katahiromz
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends cell font settings from a face-name-only string (
xg_szCellFont) to a fullLOGFONTWstruct (xg_lfCellLogFont), enabling richer font properties (weight, charset, italic, etc.) to be persisted in LOOKS files. Backward compatibility with existing LOOKS files (CellFont-only) is fully preserved.New global
LOGFONTW xg_lfCellLogFontdeclared inXG_Settings.hpp, defined/zeroed inGUI.cpplfHeight,lfWidth) are intentionally never updated from file or UI — they remain fixed (computed dynamically from cell size andxg_nCellCharPercents)LOOKS file I/O
XgExportLooks,DoExportLooks): writes bothCellFont(face name string, as before) andCellLogFont(hex-encodedLOGFONTWviaXgBinToHex)XgImportLooks,DoImportLooks): readsCellFontfirst for backward compat; ifCellLogFontis also present, deserializes viaXgHexToBin, restores all fields except size, and syncsxg_szCellFontfromlfFaceNameSync points
XgLoadSettings(registry): syncsxg_lfCellLogFont.lfFaceName←xg_szCellFontafter loadOnOK(settings dialog apply): syncsxg_lfCellLogFont.lfFaceName← dialogedt1OnChangecase 0 (ChooseFont dialog): captures fulllffromChooseFontWintoxg_lfCellLogFont, preserving size fields