Fix Step 3 validation for empty list selection - #81
Conversation
… in Step 3 Removes the 'required' attribute from the lists select element in the campaign wizard to prevent the "invalid form control is not focusable" console error caused by SlimSelect hiding the element. Adds a custom JavaScript validation check in the form submission handler to ensure at least one list is selected and displays an alert if not. Fixes #72
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
… in Step 3 Removes the 'required' attribute from the lists select element in the campaign wizard to prevent the "invalid form control is not focusable" console error caused by SlimSelect hiding the element. Adds a custom JavaScript validation check in the form submission handler to ensure at least one list is selected and displays an alert if not. Uses correct JS escaping for the alert message. Fixes #72
… in Step 3 Removes the 'required' attribute from the lists select element in the campaign wizard to prevent the "invalid form control is not focusable" console error caused by SlimSelect hiding the element. Adds a custom JavaScript validation check in the form submission handler to ensure at least one list is selected and displays an alert if not. Uses correct JS escaping for the alert message. Updates CHANGELOG.md. Fixes #72
1 participant
This PR addresses issue #72 where submitting the campaign wizard step 3 without selecting a list caused a console error instead of a visible validation message.
Changes:
admin/partials/compose-wizard.php:requiredattribute from#mskd-lists-select.PR created automatically by Jules for task 6698195851953838142 started by @katsar0v